xamarin-macios
xamarin-macios copied to clipboard
xamarin
Fix #9996 and #15622
As discussed in #9996 the CPListSection constructors are not fully correct, since the CPListImageRowItem can't be added to it, which is possible in the native iOS SDK. This PR fixes that. With that, also #15622 seems to be fixed.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@janwiebe-jump Thanks for the fix! I have some small concerts which I left in the review.
Thanks @mandel-macaque , good catch indeed.
I re-added the old constructors, and added the Obsolete attribute.
Next to that, I also added the Items[] property (besides the existing) to conform to the iOS api.
Hmm, the Items property
Lets see what the tests got to see. But the changes look good to me.
Thanks. I am curious how the duplicate Items[] works out
@janwiebe-jump I suspect is going to fail, but it an easy fix (ugly, but doable). I'll keep an eye as according tot he failures I might propose a code change.
:fire: [PR Build] Build failed :fire:
Build failed for the job 'Detect API changes'
Pipeline on Agent Hash: [PR build]
:fire: [PR Build] Build failed :fire:
Build failed for the job 'Build packages'
Pipeline on Agent Hash: [PR build]
:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire
Pipeline on Agent Hash: 671786172294a85a483a52739a29f95e8292f365 [PR build]
:fire: [PR Build] Build failed :fire:
Build failed for the job 'Build packages'
Pipeline on Agent Hash: [PR build]
:fire: [PR Build] Build failed :fire:
Build failed for the job 'Detect API changes'
Pipeline on Agent Hash: [PR build]
:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire
Pipeline on Agent Hash: 93f9fb8f208d9b24cd539bbb56f6f77779d3b7fc [PR build]
@janwiebe-jump Seems that the build is failing due to:
/Library/Frameworks/Xamarin.iOS.framework/Versions/15.13.0.27/src/Xamarin.iOS/build/dotnet/ios/generated-
sources/CarPlay/CPListSection.g.cs(157): error MT4119: Could not register the selector
'initWithItems:header:sectionIndexTitle:' of the member 'CarPlay.CPListSection..ctor' because the selector is already
registered on the member '.ctor'.
/Library/Frameworks/Xamarin.iOS.framework/Versions/15.13.0.27/src/Xamarin.iOS/build/dotnet/ios/generated-
sources/CarPlay/CPListSection.g.cs(184): error MT4119: Could not register the selector 'initWithItems:' of the member
'CarPlay.CPListSection..ctor' because the selector is already registered on the member '.ctor'.
I suspect that error is due to double exporting the ctor selectors. Let me take a look.
I believe I have corrected the PR. It at least compiles for me. I will check tomorrow.
:computer: [PR Build] Tests on macOS Mac Catalina (10.15) passed :computer:
:white_check_mark: All tests on macOS Mac Catalina (10.15) passed.
Pipeline on Agent Hash: 4ae2609c3901a3b0e5fa8e1fd93a32260c750487 [PR build]
:books: [PR Build] Artifacts :books:
Packages generated
View packages
- Microsoft.iOS.Bundle.15.4.337-ci.pr.gh15642.pkg
- Microsoft.iOS.Ref.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Runtime.ios-arm.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Runtime.ios-arm64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Runtime.iossimulator-arm64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Runtime.iossimulator-x64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Runtime.iossimulator-x86.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Sdk.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Templates.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.iOS.Windows.Sdk.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.MacCatalyst.Bundle.15.4.337-ci.pr.gh15642.pkg
- Microsoft.MacCatalyst.Ref.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.MacCatalyst.Sdk.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.MacCatalyst.Templates.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.macOS.Bundle.12.3.337-ci.pr.gh15642.pkg
- Microsoft.macOS.Ref.12.3.337-ci.pr.gh15642.nupkg
- Microsoft.macOS.Runtime.osx-arm64.12.3.337-ci.pr.gh15642.nupkg
- Microsoft.macOS.Runtime.osx-x64.12.3.337-ci.pr.gh15642.nupkg
- Microsoft.macOS.Sdk.12.3.337-ci.pr.gh15642.nupkg
- Microsoft.macOS.Templates.12.3.337-ci.pr.gh15642.nupkg
- Microsoft.NET.Sdk.iOS.Manifest-6.0.300.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.300.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.NET.Sdk.macOS.Manifest-6.0.300.12.3.337-ci.pr.gh15642.nupkg
- Microsoft.NET.Sdk.tvOS.Manifest-6.0.300.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.NET.Workload.iOS.15.4.337-ci.pr.gh15642.msi
- Microsoft.tvOS.Bundle.15.4.337-ci.pr.gh15642.pkg
- Microsoft.tvOS.Ref.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.tvOS.Runtime.tvos-arm64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.tvOS.Sdk.15.4.337-ci.pr.gh15642.nupkg
- Microsoft.tvOS.Templates.15.4.337-ci.pr.gh15642.nupkg
- xamarin.ios-15.13.0.33.pkg
- xamarin.mac-8.13.0.33.pkg
Pipeline on Agent XAMBOT-1042.Monterey' Hash: 4ae2609c3901a3b0e5fa8e1fd93a32260c750487 [PR build]
:white_check_mark: API diff for current PR / commit
Legacy Xamarin (No breaking changes)
- ~iOS~ (no change detected)
- ~tvOS~ (no change detected)
- ~watchOS~ (no change detected)
- ~macOS~ (no change detected)
NET (empty diffs)
- ~iOS~: (empty diff detected)
- ~tvOS~: (empty diff detected)
- ~MacCatalyst~: (empty diff detected)
- ~macOS~: (empty diff detected)
:heavy_exclamation_mark: API diff vs stable (Breaking changes)
Legacy Xamarin (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
.NET (:heavy_exclamation_mark: Breaking changes :heavy_exclamation_mark:)
:information_source: Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) Unable to create gist: Response status code does not indicate success: 502 (Bad Gateway). (raw diff) - Please review changes)
Pipeline on Agent Hash: 4ae2609c3901a3b0e5fa8e1fd93a32260c750487 [PR build]
:x: [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed :x:
Failed tests are:
- xammac_tests
- monotouch-test
Pipeline on Agent Hash: 4ae2609c3901a3b0e5fa8e1fd93a32260c750487 [PR build]
:fire: [CI Build] Test results :fire:
Test results
:x: Tests failed on VSTS: simulator tests
:tada: All 221 tests passed :tada:
Failures
:x: msbuild tests
:fire: Failed catastrophically on VSTS: simulator tests - msbuild (no summary found).
Html Report (VSDrops) Download
Successes
:white_check_mark: bcl: All 69 tests passed. Html Report (VSDrops) Download :white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: install_source: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 65 tests passed. Html Report (VSDrops) Download :white_check_mark: mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: mmp: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: mononative: All 12 tests passed. Html Report (VSDrops) Download :white_check_mark: monotouch: All 23 tests passed. Html Report (VSDrops) Download :white_check_mark: mtouch: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: xammac: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: xtro: All 2 tests passed. Html Report (VSDrops) Download
Pipeline on Agent Hash: [PR build]
Hi all, thanks for your reviews and input. I would like to know what is next to get this merged and released. It blocks the release of our app. Is there anything I can do? Thanks!
