xamarin-macios icon indicating copy to clipboard operation
xamarin-macios copied to clipboard

[nnyeah] sidebar navigation sample

Open stephen-hawley opened this issue 3 years ago • 8 comments

This is a port of the StoryboardSample from the Sidebar Navigation library. The code is more or less lock stock and barrel the same and I'm not hugely concerned with it.

For me, the most useful thing to get feedback on is the Makefile as I will be using it as a boilerplate for the other samples.

stephen-hawley avatar Jul 28 '22 14:07 stephen-hawley

Given the likely lifespan of this tool, I believe one time validation with the samples we have alongside early testing from internal users is the best path forward. Now that we have this additional case working, I propose we document, move forward towards internal testing, and back fill additional test cases as they come up.

chamons avatar Jul 28 '22 15:07 chamons

:seedling: [CI Build] Test results :seedling:

All tests have been skipped because the label 'skip-all-tests' was set.

Pipeline on Agent Hash: [PR build]

So do you want me to back out this PR?

stephen-hawley avatar Jul 28 '22 15:07 stephen-hawley

:computer: [PR Build] Tests on macOS Mac Catalina (10.15) passed :computer:

:white_check_mark: All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent Hash: 5dfcf0e5a7c26ea1356678f8c865c4c4dd498b68 [PR build]

:books: [PR Build] Artifacts :books:

Packages generated

View packages

Pipeline on Agent XAMBOT-1043.Monterey' Hash: 5dfcf0e5a7c26ea1356678f8c865c4c4dd498b68 [PR build]

:white_check_mark: API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • ~iOS~ (no change detected)
  • ~tvOS~ (no change detected)
  • ~watchOS~ (no change detected)
  • ~macOS~ (no change detected)
NET (empty diffs)
  • ~iOS~: (empty diff detected)
  • ~tvOS~: (empty diff detected)
  • ~MacCatalyst~: (empty diff detected)
  • ~macOS~: (empty diff detected)

:white_check_mark: API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

:white_check_mark: Generator diff

Generator diff is empty

Pipeline on Agent Hash: 5dfcf0e5a7c26ea1356678f8c865c4c4dd498b68 [PR build]

:x: [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed :x:

Failed tests are:

  • monotouch-test

Pipeline on Agent Hash: 5dfcf0e5a7c26ea1356678f8c865c4c4dd498b68 [PR build]

@dalexsoto we can make a test that is compiling the example, to avoid it to be forgotten, that will also give and end-to-end test. @stephen-hawley I think is ok, and we will need to add it as a xharness test.

mandel-macaque avatar Jul 28 '22 16:07 mandel-macaque