Nullability annotations on NSUrl

[Therzok]

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: [PR build]

[mandel-macaque]

@Therzok can you fix all the following warnings?

* Assertion at mono-threads.c:651, condition `info' not met, function:mono_thread_info_current, 
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.

@tj-devel709 give a hand if it is needed since you have experience with this changes.

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent Hash: 9f3e334aa1f3ce55c70f2eb6585fdfb4387cf945 [PR build]

[Therzok]

@Therzok can you fix all the following warnings?

* Assertion at mono-threads.c:651, condition `info' not met, function:mono_thread_info_current, 
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(716,24): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrlSessionHandler.cs(754,56): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString)'.
Foundation/NSUrl.cs(58,21): warning CS8604: Possible null reference argument for parameter 'uriString' in 'Uri.Uri(string uriString, UriKind uriKind)'.

@tj-devel709 give a hand if it is needed since you have experience with this changes.

Sure. I'm not sure about the assertion though, is it crashing on a null being passed?

[rolfbjarne]

The assertion is probably csc triggering a Mono/CoreCLR bug (causing mono or coreclr to crash) - in other words not a problem with this PR, so you can ignore it.

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent Hash: 060ed97b8a0d0379f31e92e999a6ee38f9755857 [PR build]

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent Hash: c0108ee6b2bf639858f71a0e3910fd7549415923 [PR build]

[mandel-macaque]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent Hash: c0108ee6b2bf639858f71a0e3910fd7549415923 [PR build]

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Build packages'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:computer: [PR Build] Tests on macOS Mac Catalina (10.15) passed :computer:

:white_check_mark: All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent Hash: ac7312cd84ed5833683f0577922a315fd90e5649 [PR build]

[vs-mobiletools-engineering-service2]

:books: [PR Build] Artifacts :books:

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.255-ci.pr.gh15356.pkg
• Microsoft.iOS.Ref.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Templates.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.255-ci.pr.gh15356.pkg
• Microsoft.MacCatalyst.Ref.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Templates.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Bundle.12.3.255-ci.pr.gh15356.pkg
• Microsoft.macOS.Ref.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Sdk.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Templates.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-6.0.300.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.300.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-6.0.300.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-6.0.300.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Workload.iOS.15.4.255-ci.pr.gh15356.msi
• Microsoft.tvOS.Bundle.15.4.255-ci.pr.gh15356.pkg
• Microsoft.tvOS.Ref.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Templates.15.4.255-ci.pr.gh15356.nupkg
• xamarin.ios-15.11.0.443.pkg
• xamarin.mac-8.11.0.443.pkg

Pipeline on Agent XAMBOT-1030.Monterey' Hash: ac7312cd84ed5833683f0577922a315fd90e5649 [PR build]

[vs-mobiletools-engineering-service2]

:white_check_mark: API diff for current PR / commit

Legacy Xamarin (No breaking changes)

• ~iOS~ (no change detected)
• ~tvOS~ (no change detected)
• ~watchOS~ (no change detected)
• ~macOS~ (no change detected)

NET (empty diffs)

• ~iOS~: (empty diff detected)
• ~tvOS~: (empty diff detected)
• ~MacCatalyst~: (empty diff detected)
• ~macOS~: (empty diff detected)

:white_check_mark: API diff vs stable

Legacy Xamarin (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• watchOS: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)

.NET (No breaking changes)

• iOS: vsdrops gist (No breaking changes)
• tvOS: vsdrops gist (No breaking changes)
• MacCatalyst: vsdrops gist (No breaking changes)
• macOS: vsdrops gist (No breaking changes)
• Microsoft.iOS vs Microsoft.MacCatalyst: vsdrops gist

Legacy Xamarin (stable) vs .NET

• iOS: vsdrops gist
• tvOS: vsdrops gist
• macOS: vsdrops gist

:white_check_mark: Generator diff

Generator diff is empty

Pipeline on Agent Hash: ac7312cd84ed5833683f0577922a315fd90e5649 [PR build]

[vs-mobiletools-engineering-service2]

:x: [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed :x:

Failed tests are:

• xammac_tests
• monotouch-test

Pipeline on Agent Hash: ac7312cd84ed5833683f0577922a315fd90e5649 [PR build]

[vs-mobiletools-engineering-service2]

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: simulator tests

0 tests crashed, 7 tests failed, 216 tests passed.

Failures

:x: monotouch tests

4 tests failed, 19 tests passed.

• monotouch-test/Mac Catalyst [dotnet]/Debug [dotnet]: Failed (Test run failed. Tests run: 2758 Passed: 2647 Inconclusive: 9 Failed: 1 Ignored: 110)
• monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
• monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
• monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

:x: mtouch tests

1 tests failed, 0 tests passed.

• MTouch tests/NUnit: Failed (Execution failed with exit code 19)

Html Report (VSDrops) Download

:x: xtro tests

2 tests failed, 0 tests passed.

• Xtro/Legacy Xamarin: BuildFailure
• Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

:white_check_mark: bcl: All 69 tests passed. Html Report (VSDrops) Download :white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: install_source: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 65 tests passed. Html Report (VSDrops) Download :white_check_mark: mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: mmp: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: mononative: All 12 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xammac: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: [PR Build] Build failed :fire:

Build failed for the job 'Detect API changes'

Pipeline on Agent Hash: [PR build]

[vs-mobiletools-engineering-service2]

:fire: Unable to find the contents for the comment: D:\a\1\s\change-detection\results\gh-comment.md does not exist :fire

Pipeline on Agent Hash: c0c4d5cbe6ce87e0a99f7651ee4449f2faef17cd [PR build]

[vs-mobiletools-engineering-service2]

:computer: [PR Build] Tests on macOS Mac Catalina (10.15) passed :computer:

:white_check_mark: All tests on macOS Mac Catalina (10.15) passed.

Pipeline on Agent Hash: c0c4d5cbe6ce87e0a99f7651ee4449f2faef17cd [PR build]

[vs-mobiletools-engineering-service2]

:fire: Failed to compare API and create generator diff :fire:

Error: 'make' failed for the hash 35654a1905985ffdcdfc44df828915b3753209c9.

Pipeline on Agent Hash: c0c4d5cbe6ce87e0a99f7651ee4449f2faef17cd [PR build]

[vs-mobiletools-engineering-service2]

:books: [PR Build] Artifacts :books:

Packages generated

View packages

• Microsoft.iOS.Bundle.15.4.255-ci.pr.gh15356.pkg
• Microsoft.iOS.Ref.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.ios-arm.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.ios-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.iossimulator-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.iossimulator-x64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Runtime.iossimulator-x86.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Templates.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.iOS.Windows.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Bundle.15.4.255-ci.pr.gh15356.pkg
• Microsoft.MacCatalyst.Ref.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Runtime.maccatalyst-x64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.MacCatalyst.Templates.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Bundle.12.3.255-ci.pr.gh15356.pkg
• Microsoft.macOS.Ref.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Runtime.osx-arm64.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Runtime.osx-x64.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Sdk.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.macOS.Templates.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.iOS.Manifest-6.0.300.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.MacCatalyst.Manifest-6.0.300.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.macOS.Manifest-6.0.300.12.3.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Sdk.tvOS.Manifest-6.0.300.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.NET.Workload.iOS.15.4.255-ci.pr.gh15356.msi
• Microsoft.tvOS.Bundle.15.4.255-ci.pr.gh15356.pkg
• Microsoft.tvOS.Ref.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Runtime.tvos-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-arm64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Runtime.tvossimulator-x64.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Sdk.15.4.255-ci.pr.gh15356.nupkg
• Microsoft.tvOS.Templates.15.4.255-ci.pr.gh15356.nupkg
• xamarin.ios-15.11.0.443.pkg
• xamarin.mac-8.11.0.443.pkg

Pipeline on Agent XAMBOT-1042.Monterey' Hash: c0c4d5cbe6ce87e0a99f7651ee4449f2faef17cd [PR build]

[vs-mobiletools-engineering-service2]

:x: [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) failed :x:

Failed tests are:

• xammac_tests
• monotouch-test

Pipeline on Agent Hash: c0c4d5cbe6ce87e0a99f7651ee4449f2faef17cd [PR build]

[vs-mobiletools-engineering-service2]

:fire: Failed to compare API and create generator diff :fire:

Error: 'make' failed for the hash 35654a1905985ffdcdfc44df828915b3753209c9.

Pipeline on Agent Hash: c0c4d5cbe6ce87e0a99f7651ee4449f2faef17cd [PR build]

[vs-mobiletools-engineering-service2]

:fire: [CI Build] Test results :fire:

Test results

:x: Tests failed on VSTS: simulator tests

0 tests crashed, 6 tests failed, 217 tests passed.

Failures

:x: monotouch tests

3 tests failed, 20 tests passed.

• monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
• monotouch-test/iOS Unified 64-bits - simulator/Debug (static registrar): Failed
• monotouch-test/iOS Unified 64-bits - simulator/Release (all optimizations): Failed

Html Report (VSDrops) Download

:x: mtouch tests

1 tests failed, 0 tests passed.

• MTouch tests/NUnit: Failed (Execution failed with exit code 19)

Html Report (VSDrops) Download

:x: xtro tests

2 tests failed, 0 tests passed.

• Xtro/Legacy Xamarin: BuildFailure
• Xtro/.NET: BuildFailure

Html Report (VSDrops) Download

Successes

:white_check_mark: bcl: All 69 tests passed. Html Report (VSDrops) Download :white_check_mark: cecil: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: dotnettests: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: fsharp: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: framework: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: generator: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: interdependent_binding_projects: All 7 tests passed. Html Report (VSDrops) Download :white_check_mark: install_source: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: introspection: All 8 tests passed. Html Report (VSDrops) Download :white_check_mark: linker: All 65 tests passed. Html Report (VSDrops) Download :white_check_mark: mac_binding_project: All 1 tests passed. Html Report (VSDrops) Download :white_check_mark: mmp: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: mononative: All 12 tests passed. Html Report (VSDrops) Download :white_check_mark: msbuild: All 2 tests passed. Html Report (VSDrops) Download :white_check_mark: xammac: All 3 tests passed. Html Report (VSDrops) Download :white_check_mark: xcframework: All 8 tests passed. Html Report (VSDrops) Download

Pipeline on Agent Hash: [PR build]