xamarin-forms-samples icon indicating copy to clipboard operation
xamarin-forms-samples copied to clipboard

Show forms page without pushing viewcontroller

Open lubiepomaranczki opened this issue 5 years ago • 1 comments

Description of Change

Native2Forms change.

Added sample on iOS how to display Forms ContentPage inside ViewController. This is needed when using 3rd party library. In that case, we don't want to push new ViewController because it might break our navigation. Displaying forms page within ViewController is the only option. There are limitations of this approach but I guess this is something that we need to live with.

To show how it's done, I've added NoteDetails view. Slightly changed the behaviour of the app but I hope it's fine.

Pull Request Checklist

  • [ ] Rebased on top of master at time of the pull request.
  • [x] Changes adhere to coding standard in the sample.
  • [ ] Consolidated NuGet packages across all projects in the sample (when changing existing package versions).
  • [x] Tested changes on the appropriate platforms (all platforms if changing the library code).

lubiepomaranczki avatar May 12 '20 18:05 lubiepomaranczki

I like this, a lot. I've made a couple of alterations to bring it inline with the rest of our samples.

I've also noticed that the app crashes on iOS now. That's nothing to do with your additions. Something must have changed under the hood. I've not got time to investigate at the moment, so will return to this at some point.

davidbritch avatar Aug 24 '20 15:08 davidbritch