xamarin-forms-samples icon indicating copy to clipboard operation
xamarin-forms-samples copied to clipboard

Published 20 hours ago • verified publisher icon xamarin

UWP implementation of PhotoLibrary will never create a target folder

Open Dijji opened this issue 6 years ago • 0 comments

Sample

https://github.com/xamarin/xamarin-forms-samples/tree/master/SkiaSharpForms/Demos/Demos/SkiaSharpFormsDemos.UWP

Description

There is a bug in the UWP implementation of PhotoLibrary. In SavePhotoAsync, if the target folder does not exist, then GetFolderAsync throws an exception, and so the test at line 59, if (folderDirectory == null), will always fail because folderDirectory is initialised to point at the pictures directory. Thus, the specified folder will never be created if it does not already exist.

Steps to Reproduce

  1. Run the FingerPaint demo and save a picture when there is no FingerPaint folder within Pictures

Expected Behavior

The FingerPaint folder is created and the picture is saved to it

Actual Behavior

The FingerPaint folder is not created and the picture is saved to the root pictures folder

Information

Visual Studio 2017 running UWP build of demo on Windows 10

Dijji avatar Nov 21 '19 21:11 Dijji