Xamarin.Forms
Xamarin.Forms copied to clipboard
xamarin
Move the intention of PageLifecycleManager up to the App level opposed to being at the Page level
Description of Change
PageLifecycleManager added in 4.8 needed some extra logic to detect the valid page to call OnAppearing for on iOS
Issues Resolved
- fixes #12055
Platforms Affected
- iOS
Testing Procedure
- UI Test included
PR Checklist
- [ ] Targets the correct branch
- [ ] Tests are passing (or failures are unrelated)
The revert PR is good, but with this new method, I still need a way to opt-out of page appearing/disappearing events when the app is put into the background. Android has a way to do this.
Please look at the comments on the initial PR: https://github.com/xamarin/Xamarin.Forms/pull/11172.
The revert PR is good, but with this new method, I still need a way to opt-out of page appearing/disappearing events when the app is put into the background. Android has a way to do this.
Please look at the comments on the initial PR: #11172.
This. I didn't look at the PR but I absolutely don't want to end up in a situation where OnAppearing/OnDisappearing are sent when the app goes to background or foreground, so if this would enable that behaviour please reconsider. There isn't anything that can be done on a page level in app lifecycle calls (suspend/resume) and the only thing that can be done is to try filtering out any calls originating from app lifecycle calls. The page itself doesn't appear or disappear, the app does.
If I misunderstood what this PR does I apologize.
Thank you.
This is too big of a change to still add to Xamarin.Forms at this point in time. Thanks all for the time and effort here!
