Essentials icon indicating copy to clipboard operation
Essentials copied to clipboard

Published 20 hours ago • verified publisher icon xamarin

Reading network state in the modern way

Open Snegovikufa opened this issue 3 years ago • 1 comments

Description of Change

I faced the issue with the x86_64 emulator (and Chromebook as well) when I was compiling it with the LLVM+AOT. The app started and hanged. After hours of investigation, with lots of logs added, I found the issue with the Connectivity. As I see, Connectivity used a lot of deprecated API. I updated its code according to Android recommendations:

https://developer.android.com/training/basics/network-ops/reading-network-state

Bugs Fixed

  • Related to issue #

#2035

PR Checklist

  • [ ] Has tests (if omitted, state reason in description)
  • [ ] Has samples (if omitted, state reason in description)
  • [ ] Rebased on top of main at time of PR
  • [ ] Changes adhere to coding standard
  • [ ] Updated documentation (see walkthrough)

Snegovikufa avatar Aug 12 '22 06:08 Snegovikufa

CLA assistant check
All CLA requirements met.

ghost avatar Aug 12 '22 06:08 ghost

After much consideration I have decided not to still merge this PR. While I think it definitely makes sense to get rid of the obsolete APIs, at this point in the Essentials lifespan this is a risky change that can cause breaking changes to people.

Thank you so much for your time and effort with this change!

jfversluis avatar Dec 07 '23 14:12 jfversluis