VulkanMod icon indicating copy to clipboard operation
VulkanMod copied to clipboard

Drawing mode fixes and DEBUG_LINES support

Open VisualEhrmanntraut opened this issue 1 year ago • 2 comments

This fixes mods the likes of Ad Astra amongst other problems.

image

image

VisualEhrmanntraut avatar May 03 '24 23:05 VisualEhrmanntraut

TBH I was also going to open a PR on this issue But this adds more draw modes, while my version only added Lines, so this is the better PR imho

Will link my branch anyway, just in case it is useful as a reference: https://github.com/thr3343/VulkanMod/tree/DrawMode

thr3343 avatar May 04 '24 13:05 thr3343

2024-05-04_20 58 10 MiniHUD works fine now

VisualEhrmanntraut avatar May 04 '24 18:05 VisualEhrmanntraut

I wanted to thank you for your work, I'm interested in merging this PR as it resolves a compatibility issue I haven't got around to fix yet.

xCollateral avatar May 12 '24 15:05 xCollateral

LINES mode is still a bit fishy so don't merge it yet until we figure it out :-)

VisualEhrmanntraut avatar May 13 '24 18:05 VisualEhrmanntraut

LINES mode is still a bit fishy so don't merge it yet until we figure it out :-)

That's OK, just closed my review as it was outdated

For LINES you can try quadsIndexBuffer instead of linesIndexBuffer, but oytl tested two mods with that thus far, so haven't tested that very thoroughly

thr3343 avatar May 13 '24 18:05 thr3343

@thr3343 using that only helps with the F3 cursor for me, MiniHUD still has some quirks

VisualEhrmanntraut avatar May 13 '24 18:05 VisualEhrmanntraut