Phoenix icon indicating copy to clipboard operation
Phoenix copied to clipboard

wx.adv.EVT_NOTIFICATION_MESSAGE_* Events Not implemented?

Open j4c3 opened this issue 4 years ago • 4 comments
trafficstars

The api docs reference notification events here: https://docs.wxpython.org/wx.adv.NotificationMessage.html

But, they do not appear to be defined (4.1.1, Windows 10, in VSCode.)

I had posted to the forums, but it was suggested to mention it here.

j4c3 avatar Jul 19 '21 16:07 j4c3

Yes, valid bug. They seem to be missing from the interface headers. Opened up a PR to fix it upstream: https://github.com/wxWidgets/wxWidgets/pull/2475

swt2c avatar Aug 21 '21 00:08 swt2c

These appear to have been added upstream, does this need to have them added in notifmsg.py as below as well?

module.addPyCode("""
EVT_NOTIFICATION_MESSAGE_CLICK = wx.PyEventBinder ( wxEVT_NOTIFICATION_MESSAGE_CLICK ) EVT_NOTIFICATION_MESSAGE_DISMISSED = wx.PyEventBinder ( wxEVT_NOTIFICATION_MESSAGE_DISMISSED ) EVT_NOTIFICATION_MESSAGE_ACTION = wx.PyEventBinder ( wxEVT_NOTIFICATION_MESSAGE_ACTION ) """)

j4c3 avatar Feb 28 '22 23:02 j4c3

Yes, thanks for the reminder. However the wxWidgets reference needs to be updated as well. I'm hesitant to do that without Robin's okay, though, as I don't know what his plans are.

swt2c avatar Mar 01 '22 14:03 swt2c

I just checked on this in 4.2, and it appears to remain un-implemented.

j4c3 avatar Aug 25 '22 18:08 j4c3