SpringAll
SpringAll copied to clipboard
wuyouzhuguli
Users should be able to like comments again
Agreed! I miss this feature. (It is still available on the pods using Diaspora-Pistos, because Pistos forked it before the feature was removed.)
Would be nice if the database tables were revamped...
The database table for "likes" on my pod is 1/3 of the total DB size. (131MB on a 3mo old pod) If we used the same system to let people like comments I can see database size becomming a huge problem.
I wonder if there's any way to implement the function, and cut down on database size. Google+ has +1s for comments. I wonder if they have a better method, or if they just don't care because huge databases aren't an issue for them.
... yeah, the only table on my server that is bigger than likes is participations (not by much). Not sure how we could improve this, though. You still need to save one entry of something somewhere for every like, and that is just going to get more, the more stuff you are able to like...
I wish I knew enough about Rails to even comprehend a different way to do that.
Honestly though, I like the feature myself and would use it on my pod even though it may make my DB obese. I guess one "dirty" solution would be a rake-task that would "prune" those from the DB after a period of time.
Our of curiosity: do comment likes simply belong to the "likes" table, or is there an additional table specifically for liking comments?
Yeah, every like gets put in the 'likes' table directly. From what it looks like, regardless of what is being liked (I didn't write it, but I assume you could even like a like, if the interface would allow for it...)
Please take in account that +1ing something in other languages than English sounds explicitly stupid. "Like" is easier to translate.
For referencing purposes adding link to Loomio decision
http://www.loomio.org/discussions/1035
I believe comments very often are cooler than posts, so we need a way to show appreciation of comment, not the post.
+1 ! Does anyone know the commit that removed this feature ? I'd like to see if this can easily be re-implemented
After reading these comments and loomio discussion I kinda feel that this is purely a GUI question. You could allow the pod admins enabling this feature if they are confident that the DB would handle the extra size coming from the bigger likes table and the only thing changing would be a few extra icons in the stream. If the solution you had works than I see no point of keeping it away from the users of small pods that could use this feature without any issues.
Those likes still would be federated and thus bloat the DBs of all connected pods.
Good point. Than two configs: one to enable comment likes and one to enable the propagation of them to other pods (or accepting them). Sorry, I don't know Diaspora's architecture much so I may be completely off about the possibilities...
This feature NEEDS to be back. Users of Diaspora should not miss a darn thing about fb! So whatever it takes we got to make things MUCH BETTER!!! Likes are the opinions of the people. And an open social network should never cut its budget through cutting people's ability to express their opinions. Please someone get on this.
@MaDDmin Do you know much about databases? Because IIRC the reason why comment likes were removed in the first place was due to databases becoming bogged down. Apparently, all of those likes attached to the comments make HUGE tables.
... but only because the way it was done. AFAICT this partly relates to how likes in general are stored in the DB - in the wrong way, see #4920 . They are even now bloating the DB and when that is fixed I find it hard to believe we couldn't bring this feature back as the community said yes already.
Unfortunately my time to work on this is scarce but I'll be taking looks to it... But this must be accomplished. We must stand tall and present a hard fight against those giant bs!
Heart requires no translation, and in Russian 'Like' is much dumber than +1 (Which people use in normal conversation sometimes.) Also requesting this feature, convinced it should not cause bloat. :sweet_potato:
@qm3ster as said by @jaywink https://github.com/diaspora/diaspora/issues/4920 is a blocker for this issue. Hopefully https://github.com/diaspora/diaspora/pull/6586 will be enough to close it.
How about removing author_signature for relayables which are not on the home pod of the author of a parent post? It'll be the best we can do to reduce the DB bloat.
@SuperTux88, doesn't your refactoring includes this change by any chance?
+1 for this feature. I like being able to notice someone I liked their comment without having to add a comment myself if I don't have anything meaningful to add to the conversation.
Incidentally, I doubled the bounty for this issue to $20.
Nice news, the new 0.6 version now released drastically reduced the database size. This feature could be activated again pretty easily I guess (I didn't look at the code at the moment). Does anyone here want to work on it or can I add the "help wanted" label on this one?