Gar comments

Results 500 comments of

Gar

[question]: Is there a timeline for dropping node10 support?

@cclauss that's the nodejs release cycle, nothing on there mentions node-gyp? Does this mean it can drop node10 now and it was just overlooked?

[question]: Is there a timeline for dropping node10 support?

https://github.com/nodejs/node-gyp/pull/2601

docs(readme): Add `changelog-type`

It looks like this was removed in v3?

don't call the second number a major

The docs as is accurately describe the nuances with leading zeroes in caret ranges. Removing these sections adds more confusion because it is important to call out why this behavior...

[BUG] \\ becomes \.

Duplicate of #30

feat(cache): added ability to control which response headers are stored

This is a great direction, thank you. Can we move these into `lib/options.js` so that the `defaults` method can set them?

Please add a description of node usage

Looks like the readme does have usage examples now.

fix(packument): eliminate _cached field

This seems reasonable. Can we add an assertion to one of the registry.js tests that ensures this got set?

fix(packument): eliminate _cached field

`_cached` doesn't mean that the request was fed by the cache, but that it was stored in the cache. I agree this doesn't appear to be very useful information, and...

fix(packument): eliminate _cached field

Made an issue to track https://github.com/npm/pacote/issues/183 Keep this PR open, we may just decide that removing it is a bugfix since it's a `_` attribute and was up until the...