frc-docs icon indicating copy to clipboard operation
frc-docs copied to clipboard

KOP Item resources

Open benjamin-antupit opened this issue 6 years ago • 37 comments

Copied from #25.

I would appreciate any thoughts on @firecrafty's original questions:

Feedback on how to organize this/where to put things would be great, I thought putting them in their own large section would be the right move but I'm not sure anymore as I don't want the sidebar to get too cluttered.

  • [x] vmx-pi
  • [x] Mechanical
  • [x] motors
  • [x] pneumatics
  • [x] robot quick build (put in benchtop section?)
  • [x] sensing (combine with @Oblarg's sensors section?)
  • [x] software
  • [x] wiring/connections
  • [x] other

Edit: I'll be away from the internet for two weeks (back on August 11th) and I plan to continue working on this PR when I return.

benjamin-antupit avatar Jul 23 '19 14:07 benjamin-antupit

@Daltz333 Should kop-item-resources move from docs/hardware/kop-item-resources to docs/kop-item-resources?

benjamin-antupit avatar Jul 24 '19 02:07 benjamin-antupit

Definitely keep it in hardware

Daltz333 avatar Jul 24 '19 03:07 Daltz333

Can someone help me figure out why the build is failing? Is it an Azure thing or something to do with this PR?

benjamin-antupit avatar Jul 27 '19 20:07 benjamin-antupit

Some mathematical symbol that is included that the PDF generation doesn't like. Try to use the UTF versions of symbols and minimize latex usage

Daltz333 avatar Jul 28 '19 04:07 Daltz333

(This page is the Multisim page, not the whole PR)

AustinShalit avatar Jul 28 '19 18:07 AustinShalit

The Kop should be a section under hardware. Adding each individual (hardware related) section to the main toc makes the sidebar substantially longer with little gain. Looking at things further, I see no need to even call it "Kit of Parts" (this will still make the sidebar longer, but with a benefit at least). My thoughts are, with your current organization scheme, that things can then be added to each section. (motors to motors).

Daltz333 avatar Jul 28 '19 19:07 Daltz333

@Daltz333 Anything else?

benjamin-antupit avatar Aug 24 '19 14:08 benjamin-antupit

@AustinShalit Please review.

benjamin-antupit avatar Aug 31 '19 18:08 benjamin-antupit

@Daltz333 How do you feel about moving the content located inside of the zip files out of the zip files?

AustinShalit avatar Sep 03 '19 20:09 AustinShalit

We're getting those zip files moved to other locations, and then this should be ready for merge.

Daltz333 avatar Sep 08 '19 14:09 Daltz333

Can someone rebuild this PR?

benjamin-antupit avatar Sep 12 '19 23:09 benjamin-antupit

The pull-request failing is accurate, kauai-kabs with the sub-domain vmx-pi no longer exists (the http version will redirect, and the https will fail with an invalid certification error).

Daltz333 avatar Sep 13 '19 02:09 Daltz333

The kauai labs webpage keeps going offline. I'll be contacting them about this. However, I don't see any issues with the links any more. @AustinShalit would you mind retriggering this build?

Daltz333 avatar Sep 14 '19 14:09 Daltz333

It seems to have succeeded. Would you mind fixing the last couple of redirects?

Daltz333 avatar Sep 14 '19 14:09 Daltz333

I think I fixed all the redirects and added links to https://first.wpi.edu/FRC/roborio/Docs/ where applicable. Could you also upload L4TMultimediaAPIReference.zip to https://first.wpi.edu/FRC/roborio/Docs/? It belongs in docs/hardware/sensors/jetson-tx1-developer-kit.rst line 65.

benjamin-antupit avatar Sep 14 '19 15:09 benjamin-antupit

Was that link previously hosted on ScreenSteps as well?

Daltz333 avatar Sep 14 '19 15:09 Daltz333

The file was linked on NVIDIA's website. The link label is "Multimedia Guide" and you can find it under the Documentation heading on ScreenSteps.

benjamin-antupit avatar Sep 14 '19 15:09 benjamin-antupit

Just use the original link then

Daltz333 avatar Sep 14 '19 15:09 Daltz333

Sounds good. Any other suggestions?

benjamin-antupit avatar Sep 14 '19 15:09 benjamin-antupit

Waiting on review from the individuals who put together the kit of parts.

Daltz333 avatar Sep 19 '19 16:09 Daltz333

Can someone rebuild this PR? I tried running make linkcheck locally and I don't see any errors.

benjamin-antupit avatar Sep 20 '19 01:09 benjamin-antupit

@Daltz333 Any updates on this PR?

benjamin-antupit avatar Sep 28 '19 14:09 benjamin-antupit

This is waiting on more information from the KOP team.

AustinShalit avatar Oct 01 '19 00:10 AustinShalit

I was just reviewing the changes this PR makes to the navigation sidebar. Would it be better to move all the Kit of Parts resources to one super-folder which has an index for all the KOP sub-categories (Sensors from the KOP, Control, Mechanical, Motors, Pneumatics, Robot Quick Build, Wiring & Connections and Other) to avoid adding too much to the navigation bar?

benjamin-antupit avatar Oct 05 '19 16:10 benjamin-antupit

@yellowjaguar5 now with the revision, I agree.

Daltz333 avatar Oct 06 '19 15:10 Daltz333

One of the LintCheck builds failed, but not the other one. Huh.

benjamin-antupit avatar Oct 20 '19 04:10 benjamin-antupit

Is this all fine to merge then?

Will probably have merge conflicts though.

modelmat avatar Oct 29 '19 20:10 modelmat

I want to add source files for the illustrations I created per @Daltz333's comment in #200 and then I think it will be mergeable. It would be great if this PR could get a review, though.

benjamin-antupit avatar Oct 30 '19 02:10 benjamin-antupit

We are planning on adding a lot more KoP content this season and the people doing it are more comfortable doing so in Screensteps than in RTD so our current plan is to leave all KoP content on Screensteps for this season.

Kevin-OConnor avatar Oct 30 '19 13:10 Kevin-OConnor

@yellowjaguar5 Mind updating this for the current season?

Daltz333 avatar Mar 20 '20 02:03 Daltz333