allwpilib icon indicating copy to clipboard operation
allwpilib copied to clipboard

Published 20 hours ago • verified publisher icon wpilibsuite

[commands] GenericHIDController: use composition in C++

Open spacey-sooty opened this issue 1 year ago • 3 comments

Resolves #6293 Resolves #5095 Closes https://github.com/wpilibsuite/allwpilib/pull/5097

spacey-sooty avatar Jan 22 '24 06:01 spacey-sooty

Are there any changes needed to the controller-specific classes?

Not sure but it builds so I don't think so

spacey-sooty avatar Jan 22 '24 12:01 spacey-sooty

The other HID wrappers should also be fixed to inherit from CommandGenericHID, like in Java, instead of inheriting the HID itself.

auscompgeek avatar Jan 22 '24 22:01 auscompgeek

This also resolves #5095 correct?

spacey-sooty avatar Jan 24 '24 02:01 spacey-sooty