backwpup icon indicating copy to clipboard operation
backwpup copied to clipboard

Manifest.json is erased if another file has the same name .

Open thib3113 opened this issue 7 years ago • 3 comments

On my Installation, I've a file called "manifest.json", containing the metadata for chrome android ( https://developer.chrome.com/multidevice/android/installtohomescreen#supporting ), so when I do a backup, the manifest.json created by backwpup is erased .

So I've some questions :

  • I check your code, and manifest.json don't seems to be read, so, what it his job ?
  • Can I change his name ?

thib3113 avatar Jan 24 '18 11:01 thib3113

Hi @thib3113 unfortunately we cannot change this behavior since the manifest.json is used by BackWPup to collect data about the backup and change it means doing a breaking change.

Not sure about this, need to be discussed in deep with @danielhuesken

widoz avatar Jan 28 '19 17:01 widoz

  • create a file like ___backwpup_manifest.json in the zip
  • check in your code if :
    • manifest.json exist ? seems contains your metadatas ? use it
    • else check and use ___backwpup_manifest.json

So you're backward compatible, and doens't erase the manifest.json ( or backuping the website in a subfolder in the zip ) ?

thib3113 avatar Jan 28 '19 17:01 thib3113

Thanks for the answer and the proposal.

I was thinking instead to move all of the additional files like the plugins list, manifest etc... under a directory named for example bwu-bkp rather than using prefixes for everything.

But could works also.

widoz avatar Jan 29 '19 08:01 widoz