php-cli-tools icon indicating copy to clipboard operation
php-cli-tools copied to clipboard

Published 20 hours ago • verified publisher icon wp-cli

Table::getDisplayLines() should not output excessive lines when no rows

Open slaFFik opened this issue 2 years ago • 3 comments

Fix #164.

slaFFik avatar Sep 28 '23 21:09 slaFFik

Yes, sure, I will try to do that today/tomorrow. Sorry for missing them (was in jeopardy when creating this PR and forgot to check the checks' status, my bad).

slaFFik avatar Sep 29 '23 16:09 slaFFik

@danielbachhuber, test Test_Table_Ascii::testDrawWithHeadersNoData() fixed, all checks are 🍏.

slaFFik avatar Sep 29 '23 16:09 slaFFik

@slaFFik What do you think about avoiding the back compat break? https://github.com/wp-cli/php-cli-tools/issues/164#issuecomment-1740990717

danielbachhuber avatar Sep 29 '23 18:09 danielbachhuber