GHEtool icon indicating copy to clipboard operation
GHEtool copied to clipboard

Published 20 hours ago • verified publisher icon wouterpeere

Temperature dependent fluid parameters

Open wouterpeere opened this issue 2 years ago • 4 comments

It can be nice to have temperature dependent fluid properties. Branched from issue45-restructure-package-pipe.

wouterpeere avatar May 19 '23 11:05 wouterpeere

@tblanke

I noticed you were implementing some temperature dependent fluid properties. I created a new branch for this, so we can keep better track of what changes are happening where. Currently, I'm losing a bit of an overview, since branches are no longer used for one specific implemenation/purpose.

wouterpeere avatar May 19 '23 11:05 wouterpeere

Yes, a new branch makes sense.

tblanke avatar May 19 '23 12:05 tblanke

To implement this, it would be good if this PR (https://github.com/mitchute/SecondaryCoolantProps/pull/11) gets through, rather than reimplementing everything ourselves.

wouterpeere avatar Dec 29 '23 12:12 wouterpeere

As was shown in https://github.com/mitchute/SecondaryCoolantProps/pull/11, it is not worth changing the code of the SCP package. This behaviour will hence be implemented within GHEtool itself.

wouterpeere avatar Jan 18 '24 15:01 wouterpeere

This issue is also related to issue #304 over at pygfunction (https://github.com/MassimoCimmino/pygfunction/issues/304)

wouterpeere avatar Dec 16 '24 16:12 wouterpeere

This will probably be implemented over at pygfunction.

wouterpeere avatar Jan 17 '25 13:01 wouterpeere