py-cpuinfo icon indicating copy to clipboard operation
py-cpuinfo copied to clipboard

Published 20 hours ago • verified publisher icon workhorsy

Support Wheel

Open TalAmuyal opened this issue 4 years ago • 6 comments

Support building and publishing a Wheel.

Closes #163

TalAmuyal avatar Jun 22 '21 12:06 TalAmuyal

I'm an indirect user of py-cpuinfo and I've noticed that there is no Wheel available.

Why should we care about Wheel: https://pythonwheels.com/

@workhorsy, please review this PR.

Thanks in advance :)

TalAmuyal avatar Jun 22 '21 13:06 TalAmuyal

I'll have to look into Wheel. I'm not familiar with it. I'll try it out and see, when I have time. Thanks

workhorsy avatar Jun 23 '21 07:06 workhorsy

Hi, is there anything I can do to have progress with this PR?

TalAmuyal avatar Jul 29 '21 12:07 TalAmuyal

Hi,

Sorry for the long delay - eventually I got over the procrastination.

I've added a commit that moves the --universal flag to a new setup.cfg file. In addition, it splits the clean command to 2 parts so the build command won't delete the distribution files directly after creating them.

I've tested the PR by running make build, then ls -l to see the artifacts and then make clean-dist-files to get to a clean state again.

Please let me know if you want me to make any other change.

Thanks :)

TalAmuyal avatar Jan 16 '22 13:01 TalAmuyal

Ping

TalAmuyal avatar Apr 11 '22 09:04 TalAmuyal

Would be great to get this merged. Pyodide doesn't support installing packages from source distribution and we can't use make or subprocess so we can't really support it. For now that means we can't use pytest-benchmark because this package has no wheel. See for instance https://github.com/samuelcolvin/pydantic-core/pull/118

hoodmane avatar Jun 26 '22 13:06 hoodmane

I finally had some time to research Wheel. This seems to work from my testing. Thanks for the PR

workhorsy avatar Sep 03 '22 23:09 workhorsy