WordPress-Android icon indicating copy to clipboard operation
WordPress-Android copied to clipboard

Feature Request: Support "Enter" key for Excerpt editing in Post settings #16479

Open gitstart opened this issue 3 years ago • 1 comments

Fixes #16479

Solution

Added new parameter mIsMultilineInput in PostSettingsInputDialogFragment.java to handle multiline inputs and keep single line input field if its false

To test: Click on Menu from the navigation Click on Post Click on the add button icon at the bottom right of the application Select Blog Post Click on the three dots from any of the blog post Select Post Settings Scroll down to Excerpt and click on it

Regression Notes

  1. Potential unintended areas of impact

    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Manually tested on Pixel 4 API 30 and Nexus 7 API 30

  3. What automated tests I added (or what prevented me from doing so)

    No automated tests required.

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Before fix: https://www.loom.com/share/a760faa1965d4f6295776bae31dfa51e

Demo After Fix: https://www.loom.com/share/4e5ad85d25c64b029fa1dfdc79e61e9e

gitstart avatar Aug 23 '22 15:08 gitstart

🎉 This PR now made it to the 20.9-rc-1 beta. We will now start the beta-testing phase for version 20.9 (which lasts two weeks) before rolling that version 20.9 out to end users.

Watch https://make.wordpress.org/mobile/ for the upcoming Call for Testing for WPAndroid 20.9 and to learn how to help with the beta test of this version (including your changes from this PR)!

AliSoftware avatar Oct 03 '22 11:10 AliSoftware