AztecEditor-iOS
AztecEditor-iOS copied to clipboard
wordpress-mobile
Add support for Embeds
As reported by @rachelmcr (by an original report from @kwonye):
I tested some oEmbeds and shortcodes in Aztec, and found that oEmbeds in Aztec for iOS don’t seem to be working. When I paste in a plain URL such as a YouTube or Twitter link, the URL appears in my post instead of converting to an embed. (The same URLs embedded when pasted into Aztec on Android or in a shortcode.)
We should make sure we support all the popular embeds.
This ticket requires a prior check against Aztec iOS for consistency.
List of embeds supported by WordPress.org
We should create a priority for those, probably this should be base on the use of those.
@astralbodies any way to get stats of the use of embeds on WordPress.com? I suppose Twitter, YouTube and the likes to be very popular.
Implementing this on aztec can be very complex and time consuming.
On a web view based solution we could simple implement it by mapping URL schemes to Iframes players provided by the different providers, or implement the Embed protocol to find the dynamically.
The simplest solution for us now could be detect this URL's and marked them with a special attachment type EmbedAttachmet that could be displayed in a different way.
When we tap on it we could then show a web view that shows the specific embed interface.
cc @diegoreymendez @astralbodies
I just want to clarify that the main problem is that when you paste a link into Aztec, the link itself shows up on the published post (the oEmbed completely fails to work).
Although it would be amazing to have the oEmbed work in the editor itself, my main concern is that Aztec should support pasting in URLs that are converted to oEmbeds server side.
A user brought this up after trying Aztec (internal ref: 205352-h). They expected Twitter embeds to work when created in the app.
In light of the recent crashes / reports / upcoming improvements, this is still not high in the list of priorities.
That said, we'll revisit our priorities every sprint.
Just wanted to note that this came up again in user feedback (ref: 206160-h), from a user who couldn't get Instagram and Twitter oEmbeds to work in their posts. (I want to note this so we can track user demand for this, but let me know if you'd prefer we track user feedback on this in a different way.)
That's actually very useful @rachelmcr, and I think it will be valuable for us to decide what to tackle next.
User expected YouTube embeds to work as they previously did, and wrote into support asking for help.
Internal ref: #211193-h
Just a small note, we found some really critical issues we're currently dealing with, so this will still take a bit longer before we're able to tackle it.
Will keep everyone posted here.
There's an initial effort to get pasting embeds working here: https://github.com/wordpress-mobile/AztecEditor-iOS/pull/1070
I'm reopening this since there's more work we can do in terms of supporting embeds.
I'm reopening this since there's more work we can do in terms of supporting embeds.
Thanks – this got autoclosed b/c of the merge 😅
Another request in 1607164-z, the user would like to embed Twitter statuses.
