AztecEditor-iOS icon indicating copy to clipboard operation
AztecEditor-iOS copied to clipboard

Published 20 hours ago • verified publisher icon wordpress-mobile

Improve Mark formatting

Open geriux opened this issue 3 years ago • 7 comments

Related PRs:

  • https://github.com/wordpress-mobile/gutenberg-mobile/pull/6517
  • https://github.com/WordPress/gutenberg/pull/57650
  • https://github.com/wordpress-mobile/WordPress-iOS/pull/22425

This PR fixes several issues related to the Mark formatting.

  • It completes the missing functionality implementation to fully support the Mark tag.
  • Adds MarkStringAttributeConverter which will handle toggling the format as well as returning the expected HTML format to Gutenberg, by removing the extra spaces. This was causing issues like history changes or showing the active style indicator when it shouldn't.
  • Updates MarkFormatter to set the expected CSS attributes as well as adding a color param.
  • Adds preprocessMarkForInsertion that will handle cases like auto-corrected strings, it will check if the new auto-corrected words need to have the Mark representation along with adjustAttributesForMark.
  • It also fixes toggleMark by allowing passing a color param and to be able to change colors while editing a Mark formatting or resetting the existing format.

To test

Check this PR description under the Test section. Where there are builds linked as well.

geriux avatar Mar 14 '22 08:03 geriux

Hey @twstokes 👋 I was wondering if you could help me out with a review for this PR since part of it uses the same code you added for the Heading fix for the highlighting text feature.

No worries if you can't, let me know either way. Thanks! 🙇

geriux avatar Mar 18 '22 13:03 geriux

Hey @twstokes 👋 I was wondering if you could help me out with a review for this PR since part of it uses the same code you added for the Heading fix for the highlighting text feature.

No worries if you can't, let me know either way. Thanks! 🙇

Hey @geriux! 👋 I'll be glad to. 👍

twstokes avatar Mar 18 '22 13:03 twstokes

Hey @twstokes 👋 I was wondering if you could help me out with a review for this PR since part of it uses the same code you added for the Heading fix for the highlighting text feature. No worries if you can't, let me know either way. Thanks! 🙇

Hey @geriux! 👋 I'll be glad to. 👍

🎉 thank you!

geriux avatar Mar 18 '22 14:03 geriux

👋 Hey @geriux! Is there anything I can do to help with this PR or have we decided not to pursue it for now? Thanks!

twstokes avatar Dec 14 '22 02:12 twstokes

👋 Hey @geriux! Is there anything I can do to help with this PR or have we decided not to pursue it for now? Thanks!

Hey @twstokes Thank you for reaching out! Due to other priorities, I couldn't focus on addressing your feedback but I will go back to this so we can include this fix. 🙇

geriux avatar Dec 15 '22 17:12 geriux

👋 Hey @geriux! Is there anything I can do to help with this PR or have we decided not to pursue it for now? Thanks!

Hey @twstokes Thank you for reaching out! Due to other priorities, I couldn't focus on addressing your feedback but I will go back to this so we can include this fix. 🙇

Sounds good!

twstokes avatar Dec 15 '22 17:12 twstokes

Hey there @twstokes 👋 I'm sorry this took so long to move forward but I've introduced new changes that should fix the issues you mentioned above 🚀

geriux avatar Jan 24 '24 11:01 geriux