woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

Support Dynamic Type for Payment Gateway Selection Screen

Open toupper opened this issue 3 years ago • 0 comments

From https://github.com/woocommerce/woocommerce-ios/pull/7187#issuecomment-1172418664

Nice one. I think probably merge like this, but also raise a ticket for the Dynamic Type support, unless you think you can fix it quickly? It pushes the Confirm button off screen with a 4-step font size increase on the SE simulator, and a 5-step increase on my 7 Plus.

The screen isn't usable when that happens, and there's nothing to show that there's another button hidden off screen, and no way to scroll to it:

https://user-images.githubusercontent.com/2472348/176915735-af5db65a-d0ea-4fdd-92c6-7cb6442fa13b.mp4

toupper avatar Jul 01 '22 14:07 toupper

@joshheald I checked this issue, and I think it was fixed after making the view scrollable in the context of https://github.com/woocommerce/woocommerce-ios/issues/7286: the user can scroll to reach the confirm button. I will go and close this issue now, but feel free to reopen it if you see that it is not totally fixed.

toupper avatar Sep 07 '22 15:09 toupper