woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

[Woo POS] Consider making the AnyPublisher async extension generally available

Open joshheald opened this issue 1 year ago • 1 comments
trafficstars

          Do you think it's worth making this available for other use cases? Like an extension like AnyPublisher+Async.

Originally posted by @jaclync in https://github.com/woocommerce/woocommerce-ios/pull/12928#discussion_r1625301635

joshheald avatar Jun 04 '24 08:06 joshheald

Thanks for reporting! 👍

dangermattic avatar Jun 04 '24 08:06 dangermattic

This has been open for a long time and hasn't been prioritized, I'm closing it. Having said that, feel free to re-open it if you believe it's worth working on.

malinajirka avatar Jan 25 '25 16:01 malinajirka

CC @iamgabrielma I think I recommended this to you at some point for an issue you were having; did you end up needing the async combine modifier?

joshheald avatar Jan 27 '25 09:01 joshheald

Thanks for the ping. I don't recall the exact context, I don't think I've had to use it so far but I can see how it would be helpful to adapt pieces of payments to async await as we go.

Something worth noting is that there was an update to the original article a month/couple of months after we implemented this solution, where it could be possible that the Publisher completes without emitting a value. So it could be worth revisiting/testing it if we happen to make a generally-available extension from this.

iamgabrielma avatar Jan 27 '25 12:01 iamgabrielma