woocommerce-ios icon indicating copy to clipboard operation
woocommerce-ios copied to clipboard

[Tablet Orders] Adding products when creating a new order causes -sometimes- a view glitch

Open iamgabrielma opened this issue 1 year ago • 3 comments
trafficstars

For some reason this doesn't show in the recording despite I can clearly replicate and see it on the physical device, but it does show if I make an screenshot (?)

To reproduce: ~~1. On a physical device, tap on the "scan" button to scan a product via barcode scanner to add it to the order~~ 2. Once added, tap in + to add a product from the list 3. Observe how the order creation view is not correctly shown. Tapping on the products to the left, or the bottom drawer fixes this state.

IMG_0601

iamgabrielma avatar Jan 23 '24 09:01 iamgabrielma

I can't repro this; please could you check with trunk now that everything's merged?

joshheald avatar Jan 23 '24 11:01 joshheald

Yes, this is in trunk. On an iPad Pro 12.9-inch 3rd gen, OS 15.3.1 . I've updated the title since it also happens when I don't scan products, but also when I just add products manually (It didn't happen the first times though, so is not always) 🤔

I'm not quite sure how to debug this further, this is the view hierarchy:

Screenshot 2024-01-23 at 20 08 03 Screenshot 2024-01-23 at 20 08 11

From my understanding could be pointing to an issue between the ScrollView and the grouped VStacks here. I'm wondering if could be related to some combination of the use of ScrollViewProxy and .ignoresSafeArea horizontally on that view?

iamgabrielma avatar Jan 23 '24 13:01 iamgabrielma

Yep, I can repro this on iOS 15 too. Not got time to dig in to it immediately but I'll look later. Just wanted to confirm it's not only you.

I can repro it on an iPhone in Portrait too, so it's not limited to iPad.

I can also repro it on WCiOS 16.5 (from TestFlight), which predates all the work we've done here. It's a long-standing issue.

joshheald avatar Jan 24 '24 10:01 joshheald