woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

Published 20 hours ago • verified publisher icon woocommerce

7373 replace menu calls create order

Open kidinov opened this issue 3 years ago • 3 comments

Closes: #7372 Closes: #7373

Description

Replaces deprecated menu calls:

  • OrderCreateEditFormFragment
  • OrderCreateEditCustomerAddFragment

Testing instructions

  • Open an order
  • Click edit
  • Notice that menu buttons are the same and they are working
  • Click add customer
  • Notice that menu buttons are the same and they are working
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

kidinov avatar Sep 08 '22 12:09 kidinov

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

wpmobilebot avatar Sep 08 '22 12:09 wpmobilebot

@kidinov just a nitpick comment, it might be a misunderstanding from my remark in Slack 🙂. I think we should return false from the onMenuItemSelected when the item is not relevant to us instead of returning super.onOptionsItemSelected(item) (like here), as when we do so we are still calling a deprecated function, and it triggers a warning.

hichamboushaba avatar Sep 08 '22 15:09 hichamboushaba

@hichamboushaba thanks for noticing! I missed that invocation. Fixed now

kidinov avatar Sep 15 '22 08:09 kidinov

Sorry for the long wait time! I was mostly AFK due to meetups and such. Checking now.

hafizrahman avatar Oct 05 '22 09:10 hafizrahman