woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[POS as a Tab] Remove POS entry point from Menu

Open toupper opened this issue 5 months ago • 5 comments

Do not merge label - the parent PR https://github.com/woocommerce/woocommerce-android/pull/14183 needs to be merged first.

…re flag is enabled.

Closes WOOMOB-596

Description

With this PR we hide the POS entry point in the menu if the POS as a Tab is Feature Flag is enabled, as we won't be needing that anymore: the POS can accessed through a tab.

Steps to reproduce

With the WOO_POS_AS_A_TAB_I1 feature flag enabled, and a site eligible for POS, go to menu and check that the POS entry point is not displayed. Check also that when the WOO_POS_AS_A_TAB_I1 feature flag is disabled we show the entry point as before.

  • [X] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

toupper avatar Jun 12 '25 10:06 toupper

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commited4c23e727a8ed90a1d2fec8957296cb5341ddd7
Direct Downloadwoocommerce-wear-prototype-build-pr14185-ed4c23e.apk

wpmobilebot avatar Jun 12 '25 10:06 wpmobilebot

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commited4c23e727a8ed90a1d2fec8957296cb5341ddd7
Direct Downloadwoocommerce-prototype-build-pr14185-ed4c23e.apk

wpmobilebot avatar Jun 12 '25 11:06 wpmobilebot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 37.71%. Comparing base (7efd555) to head (ed4c23e).

Additional details and impacted files
@@                             Coverage Diff                             @@
##             issue/WOOMOB-569-pos-as-a-tab-visibility   #14185   +/-   ##
===========================================================================
  Coverage                                       37.71%   37.71%           
  Complexity                                       8948     8948           
===========================================================================
  Files                                            1955     1955           
  Lines                                          109409   109410    +1     
  Branches                                        14358    14359    +1     
===========================================================================
+ Hits                                            41263    41264    +1     
  Misses                                          64392    64392           
  Partials                                         3754     3754           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 12 '25 11:06 codecov-commenter

Thanks for the review @malinajirka

Note: It seems this PR targets another PR, so we likely don't want to merge it before the parent PR is merged. In those cases, we usually leave a comment at the top of the PR description and add do not merge label to prevent us from accidentally merging it before it's ready to go.

Awesome, I didn't know that, thanks for the hint 👍

toupper avatar Jun 16 '25 14:06 toupper