woocommerce-android icon indicating copy to clipboard operation
woocommerce-android copied to clipboard

[Woo POS] Correctly Display Sub-Amounts on Totals Screen

Open backwardstruck opened this issue 1 year ago • 4 comments

Closes: #11692

Description

Changes include:

  • Display of a shimmering effect (from @kidinov) on labels while the totals are being calculated.
  • UI cleanup to better match design

Steps to reproduce

  1. Navigate to the Totals Screen.
  2. Observe the display of the subtotal, taxes, and the total.
  3. Observe the shimmering effect on the labels during the calculation.

Testing information

This PR should be tested on several scenarios to ensure correctness:

  • Devices used: Test on both Android tablet emulator.

  • Affected areas: Totals Screen.

  • Areas not tested: Other parts of the application unrelated to the Totals Screen.

  • [x] I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.


backwardstruck avatar Jun 27 '24 20:06 backwardstruck

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitadeff0500f662c42f92a44ecfcedebc32c816dfd
Direct Downloadwoocommerce-wear-prototype-build-pr11840-adeff05.apk

wpmobilebot avatar Jun 27 '24 20:06 wpmobilebot

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitadeff0500f662c42f92a44ecfcedebc32c816dfd
Direct Downloadwoocommerce-prototype-build-pr11840-adeff05.apk

wpmobilebot avatar Jun 27 '24 21:06 wpmobilebot

Make sure that we show the loading state every time when the order creation request is done. Currently it's not the case as I tested

kidinov avatar Jun 28 '24 12:06 kidinov

Codecov Report

Attention: Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.

Project coverage is 39.97%. Comparing base (0c60e22) to head (adeff05). Report is 26 commits behind head on trunk.

Files Patch % Lines
...erce/android/ui/woopos/home/WooPosHomeViewModel.kt 0.00% 10 Missing :warning:
...oid/ui/woopos/home/totals/WooPosTotalsViewModel.kt 0.00% 8 Missing :warning:
.../android/ui/woopos/common/composeui/WooPosTheme.kt 0.00% 7 Missing :warning:
...oopos/home/WooPosHomeParentToChildCommunication.kt 0.00% 4 Missing :warning:
...android/ui/woopos/home/cart/WooPosCartViewModel.kt 33.33% 4 Missing :warning:
...oopos/home/WooPosHomeChildToParentCommunication.kt 50.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##              trunk   #11840      +/-   ##
============================================
- Coverage     39.98%   39.97%   -0.02%     
  Complexity     5375     5375              
============================================
  Files          1166     1166              
  Lines         66033    66060      +27     
  Branches       9209     9216       +7     
============================================
+ Hits          26402    26406       +4     
- Misses        37185    37208      +23     
  Partials       2446     2446              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jun 28 '24 23:06 codecov-commenter

2 Warnings
:warning: This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning: Class OrderCreation is missing tests, but unit-tests-exemption label was set to ignore this.

Generated by :no_entry_sign: Danger

dangermattic avatar Jul 01 '24 08:07 dangermattic

@backwardstruck I fixed most of the issues in the PR, please take a look

There is one known - the totals are part of the "cart" card as per design. That'll require to modify home screen - I created a ticket on that

image

kidinov avatar Jul 01 '24 09:07 kidinov

@backwardstruck I fixed most of the issues in the PR, please take a look

There is one known - the totals are part of the "cart" card as per design. That'll require to modify home screen - I created a ticket on that

image

Thanks for making that ticket. Assigned to myself.

backwardstruck avatar Jul 01 '24 15:07 backwardstruck