woocommerce-android
woocommerce-android copied to clipboard
[Woo POS] Correctly Display Sub-Amounts on Totals Screen
Closes: #11692
Description
Changes include:
- Display of a shimmering effect (from @kidinov) on labels while the totals are being calculated.
- UI cleanup to better match design
Steps to reproduce
- Navigate to the Totals Screen.
- Observe the display of the subtotal, taxes, and the total.
- Observe the shimmering effect on the labels during the calculation.
Testing information
This PR should be tested on several scenarios to ensure correctness:
-
Devices used: Test on both Android tablet emulator.
-
Affected areas: Totals Screen.
-
Areas not tested: Other parts of the application unrelated to the Totals Screen.
-
[x] I have considered if this change warrants release notes and have added them to
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce-Wear Android | |
| Platform | ⌚️ Wear OS | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | adeff0500f662c42f92a44ecfcedebc32c816dfd | |
| Direct Download | woocommerce-wear-prototype-build-pr11840-adeff05.apk |
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
| App Name | WooCommerce Android | |
| Platform | 📱 Mobile | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Commit | adeff0500f662c42f92a44ecfcedebc32c816dfd | |
| Direct Download | woocommerce-prototype-build-pr11840-adeff05.apk |
Make sure that we show the loading state every time when the order creation request is done. Currently it's not the case as I tested
Codecov Report
Attention: Patch coverage is 10.25641% with 35 lines in your changes missing coverage. Please review.
Project coverage is 39.97%. Comparing base (
0c60e22) to head (adeff05). Report is 26 commits behind head on trunk.
Additional details and impacted files
@@ Coverage Diff @@
## trunk #11840 +/- ##
============================================
- Coverage 39.98% 39.97% -0.02%
Complexity 5375 5375
============================================
Files 1166 1166
Lines 66033 66060 +27
Branches 9209 9216 +7
============================================
+ Hits 26402 26406 +4
- Misses 37185 37208 +23
Partials 2446 2446
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
| 2 Warnings | |
|---|---|
| :warning: | This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews. |
| :warning: | Class OrderCreation is missing tests, but unit-tests-exemption label was set to ignore this. |
Generated by :no_entry_sign: Danger
@backwardstruck I fixed most of the issues in the PR, please take a look
There is one known - the totals are part of the "cart" card as per design. That'll require to modify home screen - I created a ticket on that
@backwardstruck I fixed most of the issues in the PR, please take a look
There is one known - the totals are part of the "cart" card as per design. That'll require to modify home screen - I created a ticket on that
![]()
Thanks for making that ticket. Assigned to myself.