Rick van Hattem

Results 315 comments of Rick van Hattem

The fix is in: https://github.com/bendavid/aiopylgtv/pull/5

I've done many tests using both this code and my own version of the code, but no matter what I do, as soon as I start handling all led's the...

Yes, that's been an issue with running esphome on these devices since the beginning for me. I've had these devices since april and I've done quite a bit of testing...

To illustrate, here's how a model like that would look (typed here in the comment box, not tested): ```python class Eggs(models.Model): pass class Sandwich(models.Model): eggs = models.ForeignKey(Eggs); spam = models.IntegerField()...

No, that's not related. I was simply writing up an example here on github and used the wrong base class :)

As a fix I currently have this: ```python def qs_filter(queryset, **filters): if not hasattr(queryset, 'model'): # No model available, can't safely expand filters return filters meta = queryset.model._meta FOREIGN_FIELDS =...

To solve the `qs_filter` hiding issue we could make DRF test for the regular validators _before_ the unique validators. A simple modification to `rest_framework.fields.Field.run_validators` could do the trick: ```python def...

That's true, the test is still limited but the patch I proposed for `qs_filter` at least takes care of a basic test already and doesn't simply skip the testing. To...

You can just call the `start()` method again, that calls the `init()` method internally which (re)sets the progressbar. I would suggest the usage of a contextmanager to make sure everything...

Even without a test it would still be useful to have this fixed, thank you for the research!