wolfssl icon indicating copy to clipboard operation
wolfssl copied to clipboard

Add conditional repository_owner to workflow

Open gojimmypi opened this issue 1 year ago • 2 comments

Description

This PR adds a workflow condition to only run the workflow on wolfssl-owned repositories (in this case, async.yml). I propose doing this on all workflows, but this PR is only for the first one to open a discussion and code review. I'm happy to make the changes for others.

Why?

I've recently begun implementing automated Espressif CI testing. One of the things that has been annoying and even problematic has been all the upstream workflows running in my fork, such as this sync from upstream:

image

Worse, some of them appear to never stop:

image

Although I think that's actually a GitHub bug, as the ones from last month are not actually running:

image

Fixes zd# n/a

Testing

How did you test?

not tested.

Checklist

  • [ ] added tests
  • [ ] updated/added doxygen
  • [ ] updated appropriate READMEs
  • [ ] Updated manual and documentation

gojimmypi avatar Aug 14 '24 15:08 gojimmypi

Update: thanks @julek-wolfssl for the tip on manually disabling workflows in a fork. That works, but I found it rather unintuitive.

I still think it's a good idea to not run all the upstream workflows by default. We could have contributors that may be time-limited on computing power or something. It just seems to be a waste. Thoughts?

gojimmypi avatar Aug 14 '24 16:08 gojimmypi

Jenkins retest this please

gojimmypi avatar Aug 14 '24 16:08 gojimmypi

Conditional Updates

After a discussion with @bandi13 I've updated all the wolfSSL workflows to conditionally run on:

if: github.repository_owner == 'wolfssl'

This condition was generally placed between the name: and runs-on: keywords.

socat_check update

I noticed a syntax highlighting error for the socat_check strategy (none was defined), so I removed it.

image

gojimmypi avatar Sep 23 '24 18:09 gojimmypi

@bandi13 please review these changes to github action tests

JacobBarthelmeh avatar Sep 26 '24 15:09 JacobBarthelmeh