pprintpp
pprintpp copied to clipboard
Merge @joaonc's pprintpp2 updates -> main
This includes #27 and #28
Thank you very kindly to @joaonc for their work on this!
Thanks for picking this up @wolever !
A few things:
- Having both tox and github actions seems redundant.
- ~Were you not insterested in the linting and security checks? black, isort, flake8, mypy, security and bandit.
I find these to be easy, low-hanging fruit procedures that bring in some benefits.~ Wait, I was looking at a commit, not the whole PR, yeah these are included, cool.
Side note: Some tests were marked as 'fix' b/c they're failing on my machine, which is Windows. I believe there's some encoding that adds \r\n instead of simply \n and tests were failing b/c of that. I was in the process of changing encoding, but not sure it's required..
Note:
- Resolves #26
- Includes #27
- Includes #28
@wolever almost there! just click merge 😃 🙏
Thanks for this! Is there anything else holding it up? Would love to see the sort_dicts option merged in 😃