Wojtek Czekalski
Wojtek Czekalski
I'm starting to notice a pattern where we put more and more logic on the objective-C side because it's more convenient/necessary. I believe we should strive to put almost everything...
This is not visible when you build the library but extremely annoying when you build an app with Brisk. Currently there are many constants hidden away from the user, like...
We have another inconsistency concerning the poly variant situation. It helps with #95 but it provides quite terrible error messages.
Those changes will make our lives much much simpler. 1. Remove this: https://github.com/briskml/brisk/blob/master/core/lib/Layout.re#L1 2. Move `core/lib/Layout.re` to `renderer-macos/lib/Styles.re` 3. Remove `core`
Items inside `NSToolbar` don't respect the size we set on the OCaml side. Probably `setFrame` for items inside `NSToolbar` should set `NSToolbarItem`'s `minSize` accordingly.
Currently `Module.component` is parsed as a module name which is obviously incorrect. It has to be parsed as a value I suppose.
In `renderer-macos/lib/stubs/BriskSegmentedControl.c` you can find that deleteItem has not been implemented. It's best to handle this after https://github.com/briskml/brisk-reconciler/issues/10
Add simple sidebar tabs and make relevant queries after switching tabs.
This should be simple. We should not call `Brisk.UI.executeHostViewUpdatesAndLayout` here: https://github.com/briskml/brisk/blob/master/renderer-macos/lib/bindings/UIEventCallback.re#L4 If there are no pending state changes.
```reason let examples = (~children as _: list(unit), ()) => Brisk.Layout.( ); ```