react-calendar icon indicating copy to clipboard operation
react-calendar copied to clipboard

Feat: Pass any Props Down to Navigation Button

Open Chaoste opened this issue 4 years ago • 6 comments
trafficstars

Summary

In our use case, we didn't want to have a clickable navigation label. This was easy to achieve via pointer-events: none but still a user can tab to this element and focus it. In a case like this, it's helpful to enable passing props through to the actual DOM element. This would also allow the developer to pass custom event listeners like onFocus or onMouseEnter.

Example usage

return (
    <Calendar navigationButtonProps={{ tabIndex: '-1' }} />
);

Chaoste avatar Apr 09 '21 12:04 Chaoste

Hey, @wojtekmaj do you have a minute to review this small PR? It's blocking me a bit and I would like to know if there's anything I should do in this PR to make it go into the next release.

Chaoste avatar Apr 13 '21 09:04 Chaoste

image

Chaoste avatar Apr 26 '21 06:04 Chaoste

giving up

Chaoste avatar Aug 18 '21 10:08 Chaoste

@wojtekmaj Sorry to ping you again, but is there a chance you could look at this PR?

Spring3 avatar Jan 17 '22 10:01 Spring3

@wojtekmaj .

Chaoste avatar Mar 01 '22 09:03 Chaoste

@wojtekmaj please :)

Chaoste avatar Mar 29 '22 12:03 Chaoste

Alrighty then

Chaoste avatar Nov 25 '22 07:11 Chaoste

@wojtekmaj .

Chaoste avatar Aug 28 '23 07:08 Chaoste

@wojtekmaj I will close this as it was ignored completely now for over two years. It's really a shame...

Chaoste avatar Sep 13 '23 09:09 Chaoste