EuIrcBot icon indicating copy to clipboard operation
EuIrcBot copied to clipboard

onUrl: Provide already-parsed URL objects to modules

Open iliana opened this issue 8 years ago • 2 comments
trafficstars

From #156:

Something I've been thinking about idly — I wonder if it'd be nice to provide the already-parsed URL object without breaking the API somehow. (The mastodon module I'm writing is just going to url.parse what it gets again.)

iliana avatar Sep 19 '17 16:09 iliana

We could pass it as a new last argument to url/dupeurl without breaking anything, I think?

LinuxMercedes avatar Sep 19 '17 16:09 LinuxMercedes

There are few enough consumers of url I'm fine not being backwards compatible. In practice, I'm not sure that the majority actually pass it straight to url.parse again though, especially since things like request libraries take strings as urls, not url objects.

euank avatar Sep 19 '17 17:09 euank