react-native-fetch-blob icon indicating copy to clipboard operation
react-native-fetch-blob copied to clipboard

0.10.9

Open lll000111 opened this issue 8 years ago • 9 comments

I fixed a handful of issues from the list. Everything is for Android except for a very small change for unlink on iOS.

lll000111 avatar Sep 06 '17 20:09 lll000111

@dantman So I pushed this too: https://github.com/wkh237/react-native-fetch-blob/pull/510/commits/68ce5c43ea2d6c226e83d21ba9b5c7777f6fccba

lll000111 avatar Sep 16 '17 13:09 lll000111

This seems to have important fixes for Android, could it be merged @wkh237 ?

CptMaumau avatar Oct 30 '17 03:10 CptMaumau

@lll000111 any chance you could merge this? I know @wkh237 is inactive, could you take over or maintain a fork?

Jacse avatar Dec 29 '17 13:12 Jacse

I can't merge because I don't have a full environment (and no iOS at all), no time, I only care(d) about the filesystem access to begin with (and only on Android). Sorry! But what prevents you from forking the repo and applying the patch? Just for yourself, doesn't even have to happen on Github. Or just use my fork and the 0.10.9 branch which has that patch: https://github.com/lll000111/react-native-fetch-blob/tree/0.10.9

lll000111 avatar Dec 29 '17 13:12 lll000111

@lll000111 thanks for the quick reply! Completely understandable. That's probably what I'll end up doing, I was just hoping to see the library maintained.

Jacse avatar Dec 29 '17 13:12 Jacse

@Jacse Given the many PRs that have accumulated I thought my call for a maintainer at the top of the README.md would yield more responses than none...

lll000111 avatar Dec 29 '17 13:12 lll000111

@lll000111 I don't mind giving a hand with the iOS maintenance

jdmunro avatar Feb 06 '18 17:02 jdmunro

@jdmunro Thanks, but I'm not maintaining anything, I became a "Collaborator" by accident, I just submitted lots of patches at some point, for stuff that I needed... The package needs to be forked and owned by somebody new, completely. All I can do is add a link to the README, I have no admin rights here.

lll000111 avatar Feb 06 '18 17:02 lll000111

@lll000111 Understood

jdmunro avatar Feb 06 '18 17:02 jdmunro