react-native-navigation icon indicating copy to clipboard operation
react-native-navigation copied to clipboard

dotIndicator is shown on the next tab when badge in null on ios

Open flexsurfer opened this issue 4 years ago • 4 comments

dotIndicator is shown on the next tab when badge is null on ios

To Reproduce

  1. Show badge
Navigation.mergeOptions('componentId', {
  bottomTab: {
    badge:"1"
  },
});
  1. Hide badge and show dotIndicator
Navigation.mergeOptions('componentId', {
  bottomTab: {
    badge:null,
    dotIndicator: {visible: true}
  },
});

Expected behavior

dotIndicator is shown for componentId tab

Actual Behavior

dotIndicator is shown for the next tab

Your Environment

  • React Native Navigation version: 7.13.0
  • React Native version: 0.63.4
  • Platform(s) (iOS, Android, or both?): iOS 13.5
  • Device info (Simulator/Device? OS version? Debug/Release?): Simulator and Device, Debug and Release

flexsurfer avatar Jun 03 '21 06:06 flexsurfer

you should set this options for bottomTab, not for bottomTabs

anagovitsyn avatar Dec 29 '21 11:12 anagovitsyn

yes, mistake in the description, fixed

flexsurfer avatar Jan 04 '22 12:01 flexsurfer

This is happening to me as well. Strange behavior.

Component IDs look right, but the dotIndicator is displayed ont the Tab with badge: null.

This along with that, I'm running in circles and becoming cuckoo lol.

eightyfive avatar Feb 13 '22 12:02 eightyfive

Ok I did run some other tests, and it does not seem to be related to badge: null in particular. It's a broader issue, it happens when "using multiple times Navigation.mergeOptions" on some/all tabs.

Hope this helps.

eightyfive avatar Feb 13 '22 12:02 eightyfive