Detox icon indicating copy to clipboard operation
Detox copied to clipboard

Fix simctrl terminate message change on v19

Open jasminmif opened this issue 1 year ago • 2 comments

The simtrl terminate error has changed again which is causing the Detox tests to fail for people still using the v19.

Can we have a new release of 19.13.1 including this fix pls. Ty

This was already fixed for v20 https://github.com/wix/Detox/pull/4171

jasminmif avatar Apr 24 '24 17:04 jasminmif

@jasminmif is there an objective reason why migrating to 19.x is impossible for you?

noomorph avatar Apr 25 '24 05:04 noomorph

@jasminmif is there an objective reason why migrating to 19.x is impossible for you?

V20 does not support Mocha so it's going to be a bug lift doing the migration.

jasminmif avatar Apr 26 '24 09:04 jasminmif

Uh-oh, I see.

Well, our build pipeline is not well optimized for backport releases, unfortunately, so it's going to be quicker for you to download detox 19.x tgz from npm. Patch it, and republish it as a scoped package, e.g. @jasminmif/detox .

I can't promise to return to build workflow tweaks/customizations/improvements earlier than mid-summer, so the previous advise may be more feasible for you.

noomorph avatar May 13 '24 10:05 noomorph

Uh-oh, I see.

Well, our build pipeline is not well optimized for backport releases, unfortunately, so it's going to be quicker for you to download detox 19.x tgz from npm. Patch it, and republish it as a scoped package, e.g. @jasminmif/detox .

I can't promise to return to build workflow tweaks/customizations/improvements earlier than mid-summer, so the previous advise may be more feasible for you.

Yeah, thats what I ended up doing. Thanks, will close this one.

jasminmif avatar May 13 '24 21:05 jasminmif