Jonatan Witoszek

Results 31 comments of Jonatan Witoszek

We should at least remove it from checkout 😅 - there's for example one type that's for some weird reason also used in SPA: https://github.com/saleor/saleor-checkout/blob/main/packages/checkout-common/src/icon.ts#L4 🙃

I had to temporarly disable tests for checking if refunds are created in Mollie and Adyen due to issues with Polly.js. We need to use the node interceptor instead of...

@mmiszy I was thinking about the `.env` file at the root of monnorepo, which is stored in respository: ``` SALEOR_API_URL=https://master.staging.saleor.cloud/graphql/ CHECKOUT_APP_URL=http://localhost:3001 SALEOR_APP_TOKEN= ``` I don't think `SALEOR_APP_TOKEN` should be there,...

@patrys Yeah, I agree. No problem wel'll change that: we have the new design on our Figma and task for that in the backlog but for now I think we...

If I may add a few cents: I think in macaw we should use a solution that outputs static CSS. This way you are free to chose whatever you need...

> The one thing that I am worried about with this approach is: that we allow to modify the transaction (transactionUpdate mutation), which means that someone different could modify the...

> ```graphql > """Represents an order in the shop.""" > type Order implements Node & ObjectWithMetadata { > ... > """Amount that is not yet refunded: grantedRefund - totalRefunded -...

> transaction.actions will be calculated by Saleor based on the amounts that are attached to the transaction I'm not sure if we should do that - some payment methods might...

@korycins > You will always know if refund has been requested on payment provider side. New webhook will require pspReference as a response from the App. But we're still discussing...

@korycins yes, `transactionEventReport` should accept `availableActions`, but maybe it should be optional - if it's not used we can have a fallback on Saleor side.