autocomplete icon indicating copy to clipboard operation
autocomplete copied to clipboard

Create spec for barnard59

Open tpluscode opened this issue 1 year ago • 7 comments

https://github.com/zazuko/barnard59/

tpluscode avatar Dec 28 '23 09:12 tpluscode

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

withfig-bot avatar Dec 28 '23 09:12 withfig-bot

Hello @tpluscode, thank you very much for creating a Pull Request! Here is a small checklist to get this PR merged as quickly as possible:

  • [ ] Do all subcommands / options which take arguments include the args property (args: {})?
  • [ ] Are all options modular? E.g. -a -u -x instead of -aux
  • [ ] Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

withfig-bot avatar Dec 28 '23 09:12 withfig-bot

I have read the CLA Document and I hereby sign the CLA

tpluscode avatar Dec 28 '23 09:12 tpluscode

recheck

tpluscode avatar Dec 28 '23 09:12 tpluscode

Thank you for the review @grant0417 . As you can see, this was generated...

About the bogus defaults. We have options with custom transforms which build a Map object. The default is an empty map, hence the JavaScript's default string representation that object. I would not like to alter the code to account for fig's autocomplete as it requires additional guards in multiple places to handle a possible undefined value for that option.

What about the linting problems? I can fix some casing but it also complains about display help for command which is generated by commander itself. And I don't know what to do about these which say If X is a single value it should not be enclosed in square brackets. I think that needs fixing in @fig/complete-commander

tpluscode avatar Jan 20 '24 20:01 tpluscode

Overview

src/barnard59.ts:

Info:

URLs:

  • https://cube.link/latest/shape/standalone-constraint-constraint

withfig-bot avatar Jan 21 '24 10:01 withfig-bot

ping @grant0417

tpluscode avatar Feb 08 '24 10:02 tpluscode

Hey @tpluscode, I have updated the @fig/complete-commander package with the fixes for the [object Map] default, can you regenerate your spec and submit again?

grant0417 avatar May 31 '24 18:05 grant0417

Done @grant0417

tpluscode avatar Jun 06 '24 07:06 tpluscode

replaced by #2365

I finally got my act together and finished set up of the fig action :)

tpluscode avatar Jun 06 '24 08:06 tpluscode