wiremock-webhooks-extension icon indicating copy to clipboard operation
wiremock-webhooks-extension copied to clipboard

optionally define a delay in webhook

Open nhomble opened this issue 5 years ago • 3 comments

A follow up from the discussion on https://github.com/wiremock/wiremock-webhooks-extension/pull/20

This change adds a delay parameter to the webhook definition. Thanks for the feedback @tomakehurst, I also would have preferred java.time.Duration but that would have required java 8+ and wasn't convinced this should be the reason to force the new version. Instead, a delay in milliseconds should reasonably cover any latency you would expect in a test.

nhomble avatar Aug 08 '20 20:08 nhomble

This change would solve my problem.

PatrickLaflamme avatar Jun 10 '21 17:06 PatrickLaflamme

@tomakehurst any concerns with this?

nhomble avatar Jun 14 '21 11:06 nhomble

Can we change it to fixedDelay for consistency with WireMock's stubbing?

Also BTW, I'm thinking of making this extension a subproject of WireMock and starting to release it with WireMock under the same version number. I think this should help avoid version conflicts in dependencies etc. and enable it to be used standalone without as much hassle.

tomakehurst avatar Jun 15 '21 11:06 tomakehurst