wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

feat: Improved delivered status indicator WPB-9170

Open svitovyda opened this issue 1 year ago • 4 comments

StoryWPB-9170 Improve hover states and paddings for delivered status

Description

Now the conversation should have additional empty space at the right, and the last delivered message should contain a translated "Delivered" indicator, visible always (instead of on mouse over). This feature design was made considering that most of the webapp/desktop users use it on res 800px+, design improvements for smaller screens will be defined later. After this version is deployed, we might implement another design with checkboxes (under a separate ticket) that can be toggled using debug

Note 1: for the first implementation, where each message had an additional div to the right: I assumed that any message header would be short enough to not wrap it into the container that takes 100% - ${deliveredIndicatorWidth}px. It might be the improvement for the next design iteration to address the small screen look

Note 2: for the second implementation, where the entire MessageList has a margin: Now the MessageList has to add and immediately remove the "Delivered" indicator to identify its width. Another option could be to add a static margin (of ~100px) and listen to the message components when one of them will have to add this indicator, then adjust the margin width. Another option could be that each message component could have a margin, but I'm not sure what we will win here

Screenshots/Screencast (for UI changes)

Screenshot 2024-06-10 at 21 32 32

Screenshot 2024-06-10 at 21 32 59

Screenshot 2024-06-10 at 21 33 36

Screenshot 2024-06-10 at 21 34 06

Screenshot 2024-06-10 at 21 35 36

Screenshot 2024-06-12 at 11 50 17

Checklist

  • [x] PR has been self reviewed by the author;
  • [x] Hard-to-understand areas of the code have been commented;
  • [ ] If it is a core feature, unit tests have been added;

svitovyda avatar Jun 10 '24 19:06 svitovyda

338319899-724d7b8e-951b-4630-8cfe-b66947348f2a regarding this image you shared -> i think the delivered status should be aligned with the time stamp at the top of longer mesages. (also timestamp should not wrap)

tlebon avatar Jun 11 '24 11:06 tlebon

Codecov Report

Attention: Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.13%. Comparing base (c0c9c7f) to head (450d23b). Report is 36 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #17553      +/-   ##
==========================================
+ Coverage   46.11%   46.13%   +0.01%     
==========================================
  Files         760      762       +2     
  Lines       25016    25025       +9     
  Branches     5721     5722       +1     
==========================================
+ Hits        11537    11546       +9     
+ Misses      12036    12035       -1     
- Partials     1443     1444       +1     

codecov-commenter avatar Jun 11 '24 14:06 codecov-commenter

338319899-724d7b8e-951b-4630-8cfe-b66947348f2a regarding this image you shared -> i think the delivered status should be aligned with the time stamp at the top of longer mesages. (also timestamp should not wrap)

I now aligned "Delivered" text to the top of the message, and also made the timestamp text nowrap (it was broken before my changes). And aligned the MessageActions to the most right - 16 px.

svitovyda avatar Jun 11 '24 18:06 svitovyda

this was superceded by #17611 and #17606

tlebon avatar Jul 18 '24 14:07 tlebon