wire-webapp icon indicating copy to clipboard operation
wire-webapp copied to clipboard

Published 20 hours ago • verified publisher icon wireapp

chore: set node version fix to 18.16

Open aweiss-dev opened this issue 1 year ago • 3 comments

All Version from 18.17 on cause crypto error in our tests.

aweiss-dev avatar Feb 27 '24 13:02 aweiss-dev

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.04%. Comparing base (2d52e3a) to head (0e6dffc).

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #16933   +/-   ##
=======================================
  Coverage   46.04%   46.04%           
=======================================
  Files         746      746           
  Lines       24383    24383           
  Branches     5577     5577           
=======================================
  Hits        11226    11226           
  Misses      11740    11740           
  Partials     1417     1417

codecov[bot] avatar Feb 27 '24 14:02 codecov[bot]

question is if this will kill our instances running in aws on node 16 🤔 i guess no if we were already set to 18

tlebon avatar Mar 06 '24 16:03 tlebon

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.04%. Comparing base (2d52e3a) to head (0e6dffc). Report is 515 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev   #16933   +/-   ##
=======================================
  Coverage   46.04%   46.04%           
=======================================
  Files         746      746           
  Lines       24383    24383           
  Branches     5577     5577           
=======================================
  Hits        11226    11226           
  Misses      11740    11740           
  Partials     1417     1417

codecov-commenter avatar Jun 24 '24 12:06 codecov-commenter