wire-server icon indicating copy to clipboard operation
wire-server copied to clipboard

Published 20 hours ago • verified publisher icon wireapp

fix typo of feature flag everywhere. Is this an API breaking change?

Open jschaul opened this issue 3 years ago • 1 comments

It looks like settings for the feature flag in helm chart never had any effects, as the parser looked for the version with captital E, not lowercase e.

Would one of you reviewers be able to amend/push-to/merge/close-unmerged this PR as needed? I don't have any context on what this is about; we just did diffing on configurations and saw this difference between old (hegemony) and new (helm based) prod configs.

jschaul avatar Jul 14 '22 13:07 jschaul

Nice catch. Sadly now there's a conflict.

Also I wouldn't call this an API change, if it wasn't working before.

elland avatar Jul 14 '22 14:07 elland

The helm chart part was fixed in #2563, see https://github.com/wireapp/wire-server/pull/2563/files#diff-252a8cec589e29d129e79ecfe2e881b1eba870106c2b1cffa618dc19b19dd54eR82-R84

The Haskell code is and remains inconsistent, but perhaps we can live with that. Someone working normally on this code can decide to follow up on this; or not.

jschaul avatar Sep 05 '22 17:09 jschaul