wire-ios icon indicating copy to clipboard operation
wire-ios copied to clipboard

refactor: create SelfUserAPI in WireAPI package - WPB-8741

Open jullianm opened this issue 1 year ago β€’ 3 comments

TaskWPB-8741 [iOS] Create SelfUserAPI

Key points

SelfUserAPI has two endpoints: getSelfUser and pushSupportedProtocols. The implementation follows the same architecture pattern as the other APIs in the package.

getSelfUser endpoint doesn't return a supportedProtocols object in v0, in v5 it does. pushSupportedProtocols is only available from api version >= 5.

Testing

Testing requests are properly created. Testing both endpoints getSelfUser and pushSupportedProtocols for failure and success. Making sure calling the pushSupportedProtocols in api versions < v5 throws an error.


Checklist

  • [ ] Title contains a reference JIRA issue number like [WPB-XXX].
  • [ ] Description is filled and free of optional paragraphs.
  • [ ] Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • [ ] Make sure you use the API for UI elements that support large fonts.
  • [ ] All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • [ ] New UI elements have Accessibility strings for VoiceOver.

jullianm avatar Aug 08 '24 16:08 jullianm

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 08 '24 16:08 CLAassistant

Test Results

130 tests   130 :white_check_mark:  0s :stopwatch:  14 suites    0 :zzz:   1 files      0 :x:

Results for commit 34abd700.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Aug 08 '24 16:08 github-actions[bot]

Datadog Report

Branch report: refactor/self-user-api Commit report: ec2ce56 Test service: wire-ios-mono

:white_check_mark: 0 Failed, 130 Passed, 0 Skipped, 114ms Total Time

datadog-wireapp[bot] avatar Aug 08 '24 16:08 datadog-wireapp[bot]