wire-android
wire-android copied to clipboard
chore: remove some non-determinism
Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro
Looking at this report: https://verification.f-droid.org/unsigned/com.wire_100083279.apk.diffoscope.html
It seems easily fixable by updating the lib to 11.5.0 or later, as this was fixed in https://github.com/mikepenz/AboutLibraries/pull/1056
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
nope @CLAassistant no can do, but anyone can pickup this change and whatever :wink:
FYI as this is a trivial change, copyright does not apply, therefore a CLA is unnecessary.
It seems that the new version of AboutLibraries requires a newer version of core-ktx, which requires a newer compile version, so it isn't building π
Hopefully these are the only surprises.
IIRC, there is a config option in aboutlibraries to turn control the inclusion of the timestamp. The timestamp used to be default on, the change was to make it default off. So you could try keeping the same library version, then just setting it to not include the timestamp.
This one: https://github.com/mikepenz/AboutLibraries/issues/784#issuecomment-1205501876
@vitorhugods @MohamadJaara to speed it up, I've applied the other fix, and you can remove it once the lib and (core-ktx) gets upgraded
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 46.02%. Comparing base (
b9c9d3c) to head (cc397b2). Report is 17 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #4000 +/- ##
===========================================
+ Coverage 46.01% 46.02% +0.01%
===========================================
Files 518 520 +2
Lines 18056 18108 +52
Branches 3031 3044 +13
===========================================
+ Hits 8309 8335 +26
- Misses 8889 8909 +20
- Partials 858 864 +6
see 16 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Ξ = absolute <relative> (impact),ΓΈ = not affected,? = missing dataPowered by Codecov. Last update b9c9d3c...cc397b2. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.