wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

chore: remove some non-determinism

Open licaon-kter opened this issue 6 months ago β€’ 7 comments
trafficstars

Your app is not built reproducible in F-Droid, but we continuously test older versions on https://verification.f-droid.org/ and would like more and more apps to become repro

Looking at this report: https://verification.f-droid.org/unsigned/com.wire_100083279.apk.diffoscope.html

It seems easily fixable by updating the lib to 11.5.0 or later, as this was fixed in https://github.com/mikepenz/AboutLibraries/pull/1056

licaon-kter avatar Apr 23 '25 11:04 licaon-kter

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 23 '25 11:04 CLAassistant

nope @CLAassistant no can do, but anyone can pickup this change and whatever :wink:

licaon-kter avatar Apr 23 '25 11:04 licaon-kter

FYI as this is a trivial change, copyright does not apply, therefore a CLA is unnecessary.

eighthave avatar Apr 23 '25 14:04 eighthave

It seems that the new version of AboutLibraries requires a newer version of core-ktx, which requires a newer compile version, so it isn't building πŸ™ƒ

Hopefully these are the only surprises.

vitorhugods avatar Apr 23 '25 18:04 vitorhugods

IIRC, there is a config option in aboutlibraries to turn control the inclusion of the timestamp. The timestamp used to be default on, the change was to make it default off. So you could try keeping the same library version, then just setting it to not include the timestamp.

eighthave avatar Apr 24 '25 05:04 eighthave

This one: https://github.com/mikepenz/AboutLibraries/issues/784#issuecomment-1205501876

licaon-kter avatar Apr 24 '25 06:04 licaon-kter

@vitorhugods @MohamadJaara to speed it up, I've applied the other fix, and you can remove it once the lib and (core-ktx) gets upgraded

licaon-kter avatar May 07 '25 08:05 licaon-kter

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.02%. Comparing base (b9c9d3c) to head (cc397b2). Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4000      +/-   ##
===========================================
+ Coverage    46.01%   46.02%   +0.01%     
===========================================
  Files          518      520       +2     
  Lines        18056    18108      +52     
  Branches      3031     3044      +13     
===========================================
+ Hits          8309     8335      +26     
- Misses        8889     8909      +20     
- Partials       858      864       +6     

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update b9c9d3c...cc397b2. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 07 '25 08:05 codecov[bot]