wire-android icon indicating copy to clipboard operation
wire-android copied to clipboard

fix: fetch MLS public keys the same way as feature config [WPB-17161]

Open saleniuk opened this issue 7 months ago • 3 comments

BugWPB-17161 [Android] Excessive frequency of fetching MLS public keys


PR Submission Checklist for internal contributors

  • The PR Title

    • [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [x] contains a reference JIRA issue number like SQPIT-764
    • [x] answers the question: If merged, this PR will: ... ³
  • The PR Description

    • [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Fetching MLS public keys should be treated the same way as feature-configs. https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/160858877/Feature+flags+and+feature+configuration#Periodic-fetch-of-configuration

Solutions

Add fetching MLS public keys to the AppSyncViewModel. Update kalium version to the one with MLS public keys changes to be able to use MLSPublicKeysSyncWorker (it executes fetch every 24h as well).

Dependencies (Optional)

Needs releases with:

  • https://github.com/wireapp/kalium/pull/3414

Testing

Test Coverage (Optional)

  • [x] I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

saleniuk avatar Apr 15 '25 14:04 saleniuk

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.44%. Comparing base (45a0143) to head (4b39fce).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3991      +/-   ##
===========================================
- Coverage    47.47%   47.44%   -0.04%     
===========================================
  Files          510      510              
  Lines        17799    17783      -16     
  Branches      2926     2926              
===========================================
- Hits          8450     8437      -13     
+ Misses        8468     8465       -3     
  Partials       881      881              
Files with missing lines Coverage Δ
...rc/main/kotlin/com/wire/android/WireApplication.kt 0.00% <ø> (ø)
...otlin/com/wire/android/ui/home/AppSyncViewModel.kt 73.68% <100.00%> (-8.14%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45a0143...4b39fce. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 15 '25 14:04 codecov[bot]

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions[bot] avatar Apr 15 '25 14:04 github-actions[bot]

This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore.

github-actions[bot] avatar May 16 '25 00:05 github-actions[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 17 '25 11:06 CLAassistant

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions[bot] avatar Jun 17 '25 12:06 github-actions[bot]

Built wire-android-dev-debug-pr-3991.apk is available for download

github-actions[bot] avatar Jun 17 '25 12:06 github-actions[bot]

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions[bot] avatar Jul 15 '25 11:07 github-actions[bot]

Built wire-android-dev-debug-pr-3991.apk is available for download

github-actions[bot] avatar Jul 15 '25 11:07 github-actions[bot]

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
bbf3c87c6319309441466844df96f2463310c5db f2e3db432ccda367dde9e817cb74fbaec4ce3c9a

Is this intentional?

github-actions[bot] avatar Jul 17 '25 13:07 github-actions[bot]

@saleniuk looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
bbf3c87c6319309441466844df96f2463310c5db 41a98896313c998d6638a1d4c9654a71ac6fbb7d

Is this intentional?

github-actions[bot] avatar Jul 17 '25 13:07 github-actions[bot]

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions[bot] avatar Jul 17 '25 13:07 github-actions[bot]

Built wire-android-dev-debug-pr-3991.apk is available for download

github-actions[bot] avatar Jul 17 '25 13:07 github-actions[bot]

Built wire-android-staging-compat-pr-3991.apk is available for download

github-actions[bot] avatar Jul 17 '25 17:07 github-actions[bot]

Built wire-android-dev-debug-pr-3991.apk is available for download

github-actions[bot] avatar Jul 17 '25 17:07 github-actions[bot]