kalium
kalium copied to clipboard
feat: Show folders in files list (WPB-17392)
|
|
PR Submission Checklist for internal contributors
-
The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like
SQPIT-764 - [x] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
Issues
Added a new data class for folders
Needs releases with:
- [ ] GitHub link to other pull request
Testing
Test Coverage (Optional)
- [ ] I have added automated test to this contribution
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
- [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.
Test Results
0 tests - 3 689 0 ✅ - 3 580 0s ⏱️ - 7m 36s 0 suites - 630 0 💤 - 109 0 files - 630 0 ❌ ± 0
Results for commit d275c9e6. ± Comparison against base commit 0faa1a20.
:recycle: This comment has been updated with latest results.
Codecov Report
Attention: Patch coverage is 48.57143% with 36 lines in your changes missing coverage. Please review.
Project coverage is 50.40%. Comparing base (
0faa1a2) to head (d275c9e).
Additional details and impacted files
@@ Coverage Diff @@
## develop #3434 +/- ##
=============================================
- Coverage 50.41% 50.40% -0.01%
+ Complexity 41 37 -4
=============================================
Files 1541 1541
Lines 59900 59919 +19
Branches 5633 5637 +4
=============================================
+ Hits 30200 30204 +4
- Misses 27604 27617 +13
- Partials 2096 2098 +2
| Files with missing lines | Coverage Δ | |
|---|---|---|
| .../kotlin/com/wire/kalium/cells/data/CellsApiImpl.kt | 9.78% <ø> (ø) |
|
| ...lin/com/wire/kalium/cells/domain/model/CellNode.kt | 100.00% <100.00%> (ø) |
|
| ...monMain/kotlin/com/wire/kalium/cells/CellsScope.kt | 0.00% <0.00%> (ø) |
|
| ...ire/kalium/cells/data/model/GetNodesResponseDTO.kt | 0.00% <0.00%> (ø) |
|
| ...m/cells/domain/usecase/GetCellFilesPagedUseCase.kt | 0.00% <0.00%> (ø) |
|
| ...tlin/com/wire/kalium/cells/data/CellsDataSource.kt | 0.00% <0.00%> (ø) |
|
| ...ire/kalium/cells/domain/paging/FilePagingSource.kt | 0.00% <0.00%> (ø) |
|
| ...ire/kalium/cells/domain/usecase/GetNodesUseCase.kt | 64.51% <33.33%> (ø) |
|
| .../kotlin/com/wire/kalium/cells/domain/model/Node.kt | 64.28% <64.28%> (ø) |
... and 3 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 0faa1a2...d275c9e. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Bencher Report
| Branch | show-folder-in-files-list |
| Testbed | ubuntu-latest |
⚠️ WARNING: No Threshold found!
Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles | 📈 view plot ⚠️ NO THRESHOLD | 690.06 µs |
| com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory | 📈 view plot ⚠️ NO THRESHOLD | 344,464.40 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark | 📈 view plot ⚠️ NO THRESHOLD | 1,493,632.69 µs |
| com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark | 📈 view plot ⚠️ NO THRESHOLD | 29,274.71 µs |
Datadog Report
Branch report: show-folder-in-files-list
Commit report: 7ac4ab1
Test service: kalium-jvm
:white_check_mark: 0 Failed, 3580 Passed, 109 Skipped, 54.27s Total Time
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code