kalium
kalium copied to clipboard
feat(async-notifications): ack events through the resusable websocket connection (WPB-16644)
|
|
PR Submission Checklist for internal contributors
-
The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like
SQPIT-764 - [x] answers the question: If merged, this PR will: ... ³
-
The PR Description
- [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability
What's new in this PR?
Issues
We need to perform ACK through the websocket after receiving and processing events.
Solutions
- Perform websocket
/eventshack for auth, using cookies instead of notifications (this endpoint won't work when consumable notifications - Make
NotificationsAPIsingleton, as we need to perform ack in the same connection. - When updating client capabilities, always declare
legalholdandconsumable-notificationsas base - Perform ACK through the websocket connection
Testing
Test Coverage (Optional)
- [x] I have added automated test to this contribution
PR Post Submission Checklist for internal contributors (Optional)
- [x] Wire's Github Workflow has automatically linked the PR to a JIRA issue
PR Post Merge Checklist for internal contributors
- [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
- https://sparkbox.com/foundry/semantic_commit_messages
- https://github.com/wireapp/.github#usage
- E.g.
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.
Test Results
3 400 tests 3 387 ✅ 5m 4s ⏱️ 6 suites 13 💤 6 files 0 ❌
Results for commit e4939213.
:recycle: This comment has been updated with latest results.
Datadog Report
Branch report: feat/newsync-doingacks
Commit report: 1f32d62
Test service: kalium-jvm
:white_check_mark: 0 Failed, 3592 Passed, 109 Skipped, 54.23s Total Time
Codecov Report
Attention: Patch coverage is 36.84211% with 72 lines in your changes missing coverage. Please review.
Please upload report for BASE (
epic/new-incremental-sync@63653e1). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## epic/new-incremental-sync #3432 +/- ##
============================================================
Coverage ? 50.39%
Complexity ? 41
============================================================
Files ? 1545
Lines ? 60166
Branches ? 5656
============================================================
Hits ? 30318
Misses ? 27751
Partials ? 2097
| Files with missing lines | Coverage Δ | |
|---|---|---|
| .../com/wire/kalium/logic/data/client/ClientMapper.kt | 47.17% <100.00%> (ø) |
|
| ...in/com/wire/kalium/logic/data/event/EventMapper.kt | 22.25% <100.00%> (ø) |
|
| ...ire/kalium/logic/sync/incremental/EventGatherer.kt | 76.82% <100.00%> (ø) |
|
| ...re/kalium/logic/sync/incremental/EventProcessor.kt | 76.74% <100.00%> (ø) |
|
| .../com/wire/kalium/logic/sync/slow/SlowSyncWorker.kt | 96.77% <100.00%> (ø) |
|
| ...base/authenticated/notification/NotificationApi.kt | 18.18% <ø> (ø) |
|
| ...om/wire/kalium/logic/data/event/EventRepository.kt | 52.29% <88.88%> (ø) |
|
| ...ponses/ConsumableNotificationEventsResponseJson.kt | 0.00% <0.00%> (ø) |
|
| ...ted/notification/ConsumableNotificationResponse.kt | 0.00% <0.00%> (ø) |
|
| ...om/wire/kalium/network/api/model/ApiModelMapper.kt | 0.00% <0.00%> (ø) |
|
| ... and 7 more |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 63653e1...e493921. Read the comment docs.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code