fix: Missed call message does not get marked as read if self user called (WPB-10208)

[ohassine]

WPB-10208 [Android] Missed call message does not get marked as read if self user called

---

PR Submission Checklist for internal contributors

• The PR Title

  • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • [ ] contains a reference JIRA issue number like SQPIT-764
  • [ ] answers the question: If merged, this PR will: ... ³

• The PR Description

  • [ ] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

Missed call message does not get marked as read if self user called

Causes (Optional)

We are updating ConversationReadDate if the message is coming from selfUser

Solutions

Exclude missedCall type so ConversationReadDate will be updated if the message is coming from self user and not a missed call.

Needs releases with:

• [ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

• [ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

---

PR Post Submission Checklist for internal contributors (Optional)

• [ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• [ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions[bot]]

Test Results

3 159 tests  +4   3 054 :heavy_check_mark: +4   3m 36s :stopwatch: +25s    542 suites +1      105 :zzz: ±0     542 files   +1          0 :x: ±0 

Results for commit 3ce970a4. ± Comparison against base commit ad1bbe20.

:recycle: This comment has been updated with latest results.

[github-actions[bot]]

Bencher

Report	Thu, August 15, 2024 at 15:38:26 UTC
Project	kalium
Branch	Missed-call-message-does-not-get-marked-as-read-if-self-user-called
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

• Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	➖ (view plot)	679,951.97
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	➖ (view plot)	444,295,130.27
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	➖ (view plot)	932,284,906.07
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	➖ (view plot)	21,442,642.97

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 52.54%. Comparing base (f755a71) to head (3ce970a). Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2953      +/-   ##
===========================================
+ Coverage    52.47%   52.54%   +0.06%     
===========================================
  Files         1290     1291       +1     
  Lines        49580    49594      +14     
  Branches      4604     4605       +1     
===========================================
+ Hits         26018    26058      +40     
+ Misses       21717    21667      -50     
- Partials      1845     1869      +24     

Files	Coverage Δ
...kalium/logic/data/message/PersistMessageUseCase.kt	21.53% <100.00%> (+21.53%)	:arrow_up:

... and 5 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f755a71...3ce970a. Read the comment docs.

[datadog-wireapp[bot]]

Datadog Report

Branch report: Missed-call-message-does-not-get-marked-as-read-if-self-user-called Commit report: b346651 Test service: kalium-jvm

:white_check_mark: 0 Failed, 3054 Passed, 105 Skipped, 13.6s Total Time