trafficstars

This PR was automatically cherry-picked based on the following PR:

#2930

Original PR description:

WPB-7153 [Android] Add flag for customer specific 1:1 calls in federated environment

This PR was automatically cherry-picked based on the following PR:

#2923

Original PR description:

PR Submission Checklist for internal contributors

The PR Title
- [x] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- [x] contains a reference JIRA issue number like SQPIT-764
- [x] answers the question: If merged, this PR will: ... ³
The PR Description
- [x] is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

A follow up PR of https://github.com/wireapp/kalium/pull/2907

When two participants are in a 1:1 MLS call on SFT, if someone ends the call, the call will stay ongoing for the other person until timout. This is because we don't rely on the SFT list, but we have a subconversation that we use for calling.

To resolve that, we agreed on a short term approch which aims to :

Not kick out the participant from subconversation if he leaves the call
Rely on SFT list by checking if the other participant has lost audio, this way the call will be terminated immediately instead of waiting for timeout.
Remove sub conversation after the 1:1 call is ended

Needs releases with:

[ ] GitHub link to other pull request

Testing

Test Coverage (Optional)

[ ] I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

[ ] Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

[ ] If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Aug 09 '24 09:08 github-actions[bot]

Test Results

3 186 tests +5 3 081 :heavy_check_mark: +5 3m 7s :stopwatch: -23s   548 suites +1   105 :zzz: ±0   548 files +1       0 :x: ±0

Results for commit 199f0a73. ± Comparison against base commit 93f96966.

:recycle: This comment has been updated with latest results.

Aug 16 '24 15:08 github-actions[bot]

Bencher

Report	Fri, August 16, 2024 at 15:18:58 UTC
Project	kalium
Branch	delete-Remote-Sub-Conversation-OneOnOneCall-On-SFT-cherry-pick-cherry-pick
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	➖ (view plot)	682,894.30
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	➖ (view plot)	377,113,595.59
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	➖ (view plot)	935,678,147.26
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	➖ (view plot)	21,744,927.00

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Aug 16 '24 15:08 github-actions[bot]

Datadog Report

Branch report: delete-Remote-Sub-Conversation-OneOnOneCall-On-SFT-cherry-pick-cherry-pick Commit report: 7577ead Test service: kalium-jvm

:white_check_mark: 0 Failed, 3081 Passed, 105 Skipped, 9.6s Total Time

Aug 16 '24 15:08 datadog-wireapp[bot]

Bencher

Report	Thu, August 29, 2024 at 08:31:21 UTC
Project	kalium
Branch	delete-Remote-Sub-Conversation-OneOnOneCall-On-SFT-cherry-pick-cherry-pick
Testbed	ubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!
Latency (latency)
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results

Benchmark	Latency	Latency Results nanoseconds (ns)
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInFiles	➖ (view plot)	688,656.96
com.wire.kalium.benchmarks.logic.CoreLogicBenchmark.createObjectInMemory	➖ (view plot)	436,482,769.23
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.messageInsertionBenchmark	➖ (view plot)	926,860,250.65
com.wire.kalium.benchmarks.persistence.MessagesNoPragmaTuneBenchmark.queryMessagesBenchmark	➖ (view plot)	21,341,015.88

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

Aug 16 '24 15:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 44.73684% with 42 lines in your changes missing coverage. Please review.

Project coverage is 52.50%. Comparing base (93f9696) to head (199f0a7).

Files with missing lines	Patch %	Lines
...gic/data/conversation/SubconversationRepository.kt	0.00%	22 Missing :warning:
.../feature/call/scenario/OnParticipantListChanged.kt	0.00%	15 Missing :warning:
.../com/wire/kalium/logic/data/call/CallRepository.kt	50.00%	1 Missing and 1 partial :warning:
...n/com/wire/kalium/logic/data/call/MLSCallHelper.kt	93.54%	0 Missing and 2 partials :warning:
.../kalium/logic/feature/call/scenario/OnCloseCall.kt	75.00%	0 Missing and 1 partial :warning:

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2942      +/-   ##
===========================================
- Coverage    52.52%   52.50%   -0.02%     
===========================================
  Files         1294     1295       +1     
  Lines        49665    49737      +72     
  Branches      4623     4635      +12     
===========================================
+ Hits         26086    26115      +29     
- Misses       21710    21748      +38     
- Partials      1869     1874       +5

Files with missing lines	Coverage Δ
...ic/data/conversation/JoinSubconversationUseCase.kt	`91.52% <ø> (ø)`
.../kalium/logic/feature/call/scenario/OnCloseCall.kt	`81.39% <75.00%> (-1.11%)`	:arrow_down:
.../com/wire/kalium/logic/data/call/CallRepository.kt	`87.53% <50.00%> (-0.48%)`	:arrow_down:
...n/com/wire/kalium/logic/data/call/MLSCallHelper.kt	`93.54% <93.54%> (ø)`
.../feature/call/scenario/OnParticipantListChanged.kt	`0.00% <0.00%> (ø)`
...gic/data/conversation/SubconversationRepository.kt	`0.00% <0.00%> (ø)`

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93f9696...199f0a7. Read the comment docs.