core-crypto icon indicating copy to clipboard operation
core-crypto copied to clipboard

Simon/test/use test conversation wpb 15788

Open SimonThormeyer opened this issue 6 months ago • 2 comments
trafficstars

What's new in this PR


PR Submission Checklist for internal contributors
  • The PR Title
    • [ ] conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • [ ] contains a reference JIRA issue number like SQPIT-764
    • [ ] answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

SimonThormeyer avatar May 15 '25 15:05 SimonThormeyer

🐰 Bencher Report

Branchsimon/test/use-test-conversation-WPB-15788
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencymilliseconds (ms)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
20.20 ms
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
5.27 ms
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
10.12 ms
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
11.37 ms
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
15.10 ms
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
17.75 ms
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
994.95 ms
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
5.21 ms
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
83.56 ms
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
220.19 ms
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
428.71 ms
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
680.72 ms
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
120.35 ms
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
27.64 ms
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
45.98 ms
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
61.86 ms
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
81.22 ms
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
97.92 ms
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold
20.54 ms
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold
118.96 ms
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold
37.81 ms
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold
59.66 ms
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold
78.92 ms
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold
98.65 ms
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
26.30 ms
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
5.17 ms
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
7.34 ms
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
10.40 ms
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
15.81 ms
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
19.80 ms
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold
28.18 ms
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold
138.88 ms
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold
116.63 ms
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold
93.54 ms
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold
72.15 ms
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold
50.60 ms
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold
139.06 ms
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold
5.25 ms
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold
32.68 ms
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold
59.37 ms
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold
87.06 ms
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold
112.88 ms
🐰 View full continuous benchmarking report in Bencher

github-actions[bot] avatar May 15 '25 15:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 95.22059% with 13 lines in your changes missing coverage. Please review.

Project coverage is 81.23%. Comparing base (a57a723) to head (a2dd858). Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
crypto/src/test_utils/test_conversation.rs 90.22% 13 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1140      +/-   ##
==========================================
+ Coverage   80.81%   81.23%   +0.41%     
==========================================
  Files         166      166              
  Lines       21431    21386      -45     
==========================================
+ Hits        17320    17372      +52     
+ Misses       4111     4014      -97     
Files with missing lines Coverage Δ
crypto/src/mls/conversation/commit.rs 95.07% <100.00%> (-0.50%) :arrow_down:
crypto/src/mls/conversation/commit_delay.rs 100.00% <100.00%> (ø)
...tion/conversation_guard/decrypt/buffer_messages.rs 99.23% <100.00%> (ø)
...mls/conversation/conversation_guard/decrypt/mod.rs 97.94% <100.00%> (ø)
crypto/src/mls/conversation/duplicate.rs 98.41% <100.00%> (ø)
...rypto/src/mls/conversation/leaf_node_validation.rs 97.34% <100.00%> (+0.07%) :arrow_up:
crypto/src/mls/conversation/mod.rs 97.00% <100.00%> (ø)
crypto/src/mls/conversation/orphan_welcome.rs 100.00% <100.00%> (ø)
...rypto/src/mls/conversation/pending_conversation.rs 98.68% <100.00%> (ø)
crypto/src/mls/conversation/proposal.rs 72.54% <100.00%> (ø)
... and 13 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a57a723...a2dd858. Read the comment docs.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar May 15 '25 15:05 codecov-commenter