wing icon indicating copy to clipboard operation
wing copied to clipboard

fix(console): respect `node.title` in the map view

Open skyrpex opened this issue 1 year ago • 4 comments

Update the display of node names in the MapView component to show the title if available, falling back to the id if not.

Fixes #6457.

skyrpex avatar May 13 '24 07:05 skyrpex

Thanks for opening this pull request! :tada: Please consult the contributing guidelines for details on how to contribute to this project. If you need any assistence, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

github-actions[bot] avatar May 13 '24 07:05 github-actions[bot]

Console preview environment is available at https://wing-console-pr-6464.fly.dev :rocket:

Last Updated (UTC) 2024-05-16 12:44

monadabot avatar May 13 '24 08:05 monadabot

Is there a way to test this?

We have to revisit the test suite and then we could start adding the tests back. But right now they are just being skipped.

skyrpex avatar May 13 '24 09:05 skyrpex

Bummer

On Mon, May 13, 2024 at 12:32 PM Cristian Pallarés @.***> wrote:

Is there a way to test this?

We have to revisit the test suite and then we could start adding the tests back. But right now they are just being skipped.

— Reply to this email directly, view it on GitHub https://github.com/winglang/wing/pull/6464#issuecomment-2107094394, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAESGDF6GB7DZJQ6QD7MQPLZCCCCTAVCNFSM6AAAAABHTVZ6MGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBXGA4TIMZZGQ . You are receiving this because you commented.Message ID: @.***>

eladb avatar May 13 '24 10:05 eladb

Thanks for contributing, @skyrpex! This PR will now be added to the merge queue, or immediately merged if respect-node-title-in-the-map-view is up-to-date with main and the queue is empty.

mergify[bot] avatar May 16 '24 14:05 mergify[bot]

Congrats! :rocket: This was released in Wing 0.73.49.

monadabot avatar May 16 '24 14:05 monadabot